1555653 - [wayland] assertion of unlocked buffer fails on WindowBackBufferShm

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Horak [:jhorak]]

In debug build, there's an assert on two locations:
[1] - the implementation of WindowBackBufferShm::IsLocked is missing
[2] - the mPendingCommit is set by WindowSurfaceWayland::Commit and then CommitWaylandBuffer is called which flushes the cached drawings by getting LockWaylandBuffer which calls GetWaylandBufferToDraw and asserts that mPendingCommit is false. I guess the assert is not relevant as we no longer do the double buffering.

[1] https://dxr.mozilla.org/mozilla-central/rev/9131063a5ce0676336736f15d01bb5d9a2b9ad32/widget/gtk/WindowSurfaceWayland.cpp#968
[2] https://dxr.mozilla.org/mozilla-central/rev/9131063a5ce0676336736f15d01bb5d9a2b9ad32/widget/gtk/WindowSurfaceWayland.cpp#596

Comment 1

[Jan Horak [:jhorak]]

Attachment: Bug 1555653 Fix asserts in WindowBackBufferShm; r=stransky

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ecaa6d17535
Fix asserts in WindowBackBufferShm; r=stransky

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1ecaa6d17535