Closed
Bug 1555657
Opened 5 years ago
Closed 5 years ago
toolbarbutton[is="toolbarbutton-menu-button"] shows the dropmarker in the customize window
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
(Keywords: regression)
Attachments
(1 file)
769 bytes,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
When customizing a toolbar, the toolbarbuttons[is="toolbarbutton-menu-button"] shows the dropmarker in the customize window. This wouldn't be a issue but the button is vertically oriented instead of horizontally.
Assignee | ||
Comment 1•5 years ago
|
||
Magnus, what should we do here?
- Only orient them horizontally and let the dropmarker show? or
- Hide the dropmarker through CSS to look like before the de-XBL? or
- Hide the dropmarker in the oolbarbutton-menu-button constructor (or how it is named)?
The first two I can do, the third needs a de-XBL specialist.
Flags: needinfo?(mkmelin+mozilla)
Comment 2•5 years ago
|
||
I think "Hide the dropmarker through CSS to look like before the de-XBL" would be good.
Flags: needinfo?(mkmelin+mozilla)
Summary: toolbarbutton[is="toolbarbutton-menu-button"] shows in customize window the dropmarker → toolbarbutton[is="toolbarbutton-menu-button"] shows the dropmarker in the customize window
Assignee | ||
Comment 3•5 years ago
|
||
Hide it.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9068677 -
Flags: review?(mkmelin+mozilla)
Comment 4•5 years ago
|
||
Comment on attachment 9068677 [details] [diff] [review] 1555657-hide-dropmarker.patch Review of attachment 9068677 [details] [diff] [review]: ----------------------------------------------------------------- r=mkmelin
Attachment #9068677 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a6bbb29b55e5
Hide the toolbarbutton-menubutton-dropmarker in customize window. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 69.0
You need to log in
before you can comment on or make changes to this bug.
Description
•