Closed Bug 1555664 Opened 6 years ago Closed 3 years ago

[meta] Audit callers of nsIFrame::Type()

Categories

(Core :: Layout, task)

task
Not set
normal

Tracking

()

RESOLVED INCOMPLETE
Tracking Status
firefox69 --- affected

People

(Reporter: MatsPalmgren_bugz, Unassigned)

References

Details

(Keywords: meta)

nsIFrame::Type() is a foot-gun and we would like to replace it with better
alternatives eventually. Before that happens we should audit all callers
to see what it's used for, and replace it with alternatives when possible,
such as do_QueryFrame or Is__Frame.

(This is a meta-bug. Please file any code changes resulting from
the audit as blocking this bug.)

Summary: Audit callers of nsIFrame::Type() → [meta] Audit callers of nsIFrame::Type()

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:dholbert, maybe it's time to close this bug?

Flags: needinfo?(dholbert)
Flags: needinfo?(dholbert)

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:dholbert, maybe it's time to close this bug?

Flags: needinfo?(dholbert)

Yeah, I'm not aware of specific plans around this. I'll file a bug for some minor s/Type()/Is___Frame/ conversion opportunities that I noticed, but I'm not sure there's more to be done here.

Closing this as "incomplete" as a metabug. If we have specific plans/goals here, we can reopen with those & with dependent bugs.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(dholbert)
Resolution: --- → INCOMPLETE
See Also: → 1777605
You need to log in before you can comment on or make changes to this bug.