1555681 - 500 Error is displayed after declining the Merge warning for a new mail

Status: VERIFIED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Timea Cernea [:tbabos][inactive]]

Affected versions:
67.0.1 (64-bit)

Affected platforms:
Windows 7 x64

Prerequisites:
To be able to see the about:welcome page on a version where this is not implemented please go to about:config and set:

identity.fxaccounts.autoconfig.uri to https://accounts.stage.mozaws.net
browser.newtabpage.activity-stream.fxaccounts.endpoint to https://accounts.stage.mozaws.net
Restart the browser.

Steps to reproduce:

• Launch the browser
• Sign in to a verified FXA account
• Go to about:welcome
• Fill in a new e-mail address
• Click on "Cancel" for the Merge warning

Actual result:
500 Error
Oh dear, something went wrong there. We've been notified and will get working on a fix.

Expected result:
A different, more user friendly message should be displayed.

Recording: https://streamable.com/86rph

Comment 1

[Shane Tomlinson [:stomlinson]]

I think to fix this, we need to add AuthErrors.is(error, 'USER_CANCELED_LOGIN') here: [1]

[1] - https://github.com/mozilla/fxa/blob/557dcdbb4c4f43fb699b7b0682bab83e6a767ea4/packages/fxa-content-server/app/scripts/lib/error-utils.js#L25

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

An update is now pushed so we can re-test. Timea can you try again? Thanks.

Comment 3

[Wil Clouser [:clouserw]]

Fix was here: https://github.com/mozilla/fxa/commit/241056d15076ae9e0a245815db2d34872fbd6e81

Comment 4

[Wil Clouser [:clouserw]]

Closing based on comment 2. Please verify. Thanks

Comment 5

[Timea Cernea [:tbabos][inactive]]

Attachment: Expected

Verified - Fixed on Windows 7/10, Mac OS 10.14 and Ubuntu 18.04.
Attached expected behavior.