1555733 - notify event 'paused' threw an exception

Status: NEW

(DevTools :: Framework, task, P3)

Description

[Jason Laster [:jlast]]

I've been seeing this exception fairly consistently over the past couple of months. I would guess it is due to the recent thread-client refactoring.

console.error: "notify event 'paused' threw an exception: TypeError: packet.why is undefined

Stack: onPaused@chrome://devtools/content/framework/toolbox-process-window.js:204:9
eventSource/proto.emit@resource://devtools/shared/client/event-source.js:128:27
_onThreadState@resource://devtools/shared/client/thread-client.js:357:40
onPacket@resource://devtools/shared/client/debugger-client.js:637:38
_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:451:20
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:22
Line: 204, column: 9"

Comment 1

[Jason Laster [:jlast]]

CC Yulia, does this look familiar?

Comment 2

[Yulia Startsev [:yulia]]

This is unrelated to the threadClient refactor, and I haven't seen it before.

I took a look briefly, here is what i found:

https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js#1531
this is incorrectly formatted. it should be this.packet.why = { type: "replayForcedPause" };
But, it doesn't look like the source of the error.

Locations where an error might happen are the _paused() and _pauseAndRespond() methods on the threadActor.
For the former, it needs to have a packet.why = { type: ... }; set explicitly.
For the latter -- you have to pass a second argument for the reason in the following format: _pauseAndRespond(_, { type:.... }, _).

However, all of the instances that I found look like they are correctly used.

Without more information, such as an str, I can't say much more.