Closed Bug 1555780 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17105 - [LayoutNG] Fix `vertical-align: top/bottom` not to include paddings

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17105 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17105
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix vertical-align: top/bottom not to include paddings

This patch fixes the top and bottom of inline boxes for the
top and bottom values of vertical-align not to include
their paddings.

The spec1 says align with the top/bottom of boxes. Line
box in CSS is special that paddings are included to draw
background and borders, but are not included when computing
their heights2. All impls agree that the top/bottom in this
case is the latter; i.e., not to include paddings.

Bug: 968438
Change-Id: I034d0390e3695e8a3fcc737f94fc5561e16cd617

Reviewed-on: https://chromium-review.googlesource.com/1637006
WPT-Export-Revision: ef5a8eec73b9909140ecb3e573faaae8acdbe3f2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4841ed584343
[wpt PR 17105] - [LayoutNG] Fix `vertical-align: top/bottom` not to include paddings, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4841ed584343

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.