Enable webrtc use of socket process on nightly by default
Categories
(Core :: WebRTC: Networking, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
(Blocks 2 open bugs, Regressed 1 open bug)
Details
Attachments
(5 files, 1 obsolete file)
This includes setting the default value of media.peerconnection.mtransport_process and network.process.enabled to true in nightly, as well as ensuring that spi tests are run in CI iff the '-spi' suffix is present (in other words, CI should always stomp the default value of these prefs).
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dff519f4a4d171da92de6236d101b1a30ef3125b
Assignee | ||
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ae6d6e8818e82af2dcf46f015da8b1f6917b6f9
Assignee | ||
Comment 3•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c0a012b24700a53998592305bdd309e5ca0f80a
Assignee | ||
Comment 4•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18fabb86501f54d0b9fe2343ce068144443b4b65
Assignee | ||
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c330654162ed3c8725c7c3830ec902bee0803bc7
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=812bab9724662aa3b5e9a573cfc00d2250716515
Assignee | ||
Comment 7•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5af885a35ea86f33122cbbd11aed952ed4c578ec
Assignee | ||
Comment 8•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd1cf4be31c4e275b4cc8bedd144d9e96f6efc9e
Assignee | ||
Comment 9•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74562ecbf67d193615cdc12a67f5a98b9b09dff9
Assignee | ||
Comment 10•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=842fdc7c3cde18a4971a7c3bd077bb2f5b6821f4
Assignee | ||
Comment 11•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a40a71017ddb4d4ae309dcb98a93f5163b495a46
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
Depends on D33643
Assignee | ||
Comment 14•5 years ago
|
||
Try has some infra failures it looks like, retriggering.
Updated•5 years ago
|
Comment 15•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54ed41058000 Set the socket-process-isolation prefs to true on nightly. r=mjf https://hg.mozilla.org/integration/autoland/rev/8cff011ed07a Ensure that the new default values for nightly have no effect on CI. r=ahal
Comment 16•5 years ago
|
||
Backed out 2 changesets (Bug 1555792) for Windows 2012 build bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/de019903849effdf777f3acb56d37ee31b888305
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250464983&repo=autoland&lineNumber=47690
22:15:39 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1559856130/build/src/obj-firefox/browser/tools/mozscreenshots/mozscreenshots/extension'
22:15:42 INFO - mozmake.EXE[2]: Entering directory 'z:/task_1559856130/build/src/obj-firefox'
22:15:42 INFO - z:/task_1559856130/build/src/clang/bin/llvm-profdata.exe merge -o ./merged.profdata ./*.profraw
22:15:42 INFO - error: ./default_6044_random_7401113781408603760_0.profraw: Invalid instrumentation profile data (file header is corrupt)
22:15:42 INFO - Makefile:287: recipe for target 'maybe_clobber_profiledbuild' failed
22:15:42 INFO - mozmake.EXE[2]: *** [maybe_clobber_profiledbuild] Error 1
22:15:42 INFO - mozmake.EXE[2]: Leaving directory 'z:/task_1559856130/build/src/obj-firefox'
22:15:42 INFO - Makefile:186: recipe for target 'profiledbuild' failed
22:15:42 INFO - mozmake.EXE[1]: *** [profiledbuild] Error 2
22:15:42 INFO - client.mk:125: recipe for target 'build' failed
22:15:42 INFO - mozmake.EXE: *** [build] Error 2
22:15:42 INFO - 225 compiler warnings present.
22:15:42 ERROR - Return code: 2
22:15:42 WARNING - setting return code to 2
22:15:42 FATAL - 'mach build -v' did not run successfully. Please check log for errors.
22:15:42 FATAL - Running post_fatal callback...
22:15:42 FATAL - Exiting -1
22:15:42 INFO - [mozharness: 2019-06-06 22:15:42.358000Z] Finished build step (failed)
22:15:42 INFO - Running post-run listener: _parse_build_tests_ccov
22:15:42 INFO - Running post-run listener: _shutdown_sccache
22:15:42 INFO - Running post-run listener: _summarize
22:15:42 ERROR - # TBPL FAILURE #
22:15:42 INFO - [mozharness: 2019-06-06 22:15:42.358000Z] FxDesktopBuild summary:
22:15:42 ERROR - # TBPL FAILURE #
[taskcluster 2019-06-06T22:15:42.376Z] Exit Code: 4294967295
[taskcluster 2019-06-06T22:15:42.376Z] User Time: 15.625ms
[taskcluster 2019-06-06T22:15:42.376Z] Kernel Time: 0s
[taskcluster 2019-06-06T22:15:42.376Z] Wall Time: 42m49.2837397s
[taskcluster 2019-06-06T22:15:42.376Z] Result: FAILED
Assignee | ||
Comment 17•5 years ago
|
||
So I saw this failure on try, but a retrigger cleared it up. I had assumed it was infra, because I haven't touched any c++ code in either of these patches. How would touching prefs.js cause the prof builds to corrupt their profile data, anyway?
Comment 18•5 years ago
|
||
I can only observe that the bustages seem to start with your changes and seem to turn green on the backout, sorry, can't think how your changes affect the builds.
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C2012%2Cshippable%2Cbuild&fromchange=586b27e0e8114f514b71558620ca849abea9d477&tochange=c5a178862298231ac3c47b6d4631a2df3c6499c6&selectedJob=250464983
Assignee | ||
Comment 19•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a16cf1ec70930bc3f26da919ac5b2c899ea1c3be
Assignee | ||
Comment 20•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ffba427bfdf84c5588a17fa60bc48dccb945d0a
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 21•5 years ago
|
||
Depends on D33644
Assignee | ||
Comment 22•5 years ago
|
||
Seeing some weird new errors on android pgo now.
Assignee | ||
Comment 23•5 years ago
|
||
Looks like I need to edit this file and add an entry for the socket process?
Assignee | ||
Comment 24•5 years ago
|
||
Depends on D34748
Assignee | ||
Comment 25•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=278186a34f5c22553db9b025a5d0db868787b7a9
Assignee | ||
Comment 26•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2278e8d7bb6e9b33f04aa5c956ac6b97bce70c74
Assignee | ||
Comment 27•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=43b40e14d07688997e4c7ba5eba112a1ad11dc2a
Comment 28•5 years ago
|
||
bwc confirmed this won't get done in time for M3, so punting to M4 for now.
Assignee | ||
Comment 29•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5a4a9987b2a8ebf87a8827c81f6e8ab52f5e777
Updated•5 years ago
|
Assignee | ||
Comment 30•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=07a68bed2cdec116f530710db0bc6ad717dc61c6
Patch looks right to me!
Assignee | ||
Comment 32•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=737e72c4082846fc0d5657efcf50db7bbeedbc4d
Assignee | ||
Comment 33•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6589bdf39ea3cf0aa157d83553493f2e9e942d43
Assignee | ||
Comment 34•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c8c0a077832b4a72099b74aaa4668be5c0a0dd3
Assignee | ||
Comment 35•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=521726bc096c61e2a723882a3e0cc35f9b5ebace
Assignee | ||
Comment 36•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cd0e9504cd0f902e106542b16901c25e6b3b182
Assignee | ||
Comment 37•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02d8d1b6cb7a08d5673cd144cb569cc78b2e5824
Assignee | ||
Comment 38•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=43758e5bc05dd509a3f6be94a75a10e5757d79a0
Assignee | ||
Comment 39•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37075122012e25457ab8d5c3865bdec8a4d95a58
Assignee | ||
Comment 40•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52a2184dd8aca4ddf5701376b34750ad7d96aae5
Assignee | ||
Comment 41•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ae58f248d334509eba80c20748e9f1786ab0a34
Assignee | ||
Comment 42•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=768ec02fd5629253a39f3d437fdfd26d1df1f4ba
Assignee | ||
Comment 43•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1261f79579152abea039d4eefa1af84c8fd25afe
Assignee | ||
Comment 44•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=599828fdeb7aff9d4ca8c8fa05f6acf6e814fb1a
Assignee | ||
Comment 45•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19e486cc17ef1f8e0d95bce1d0a2a887077af264
Assignee | ||
Comment 46•5 years ago
•
|
||
Looks like putting quotes around --setpref values (like this) prevents them from being parsed by some test-scripts (like this). I am fixing the cases that involve our socket process prefs, but all other uses of --setpref probably need to be fixed, or we need to strip out quotes on them.
Edit: Also, the try push in comment 44 has a lot of failures in OS 10.10 debug browser-chrome mochitests; the socket process was running on these tests, but those tests aren't running against a shippable build, which means that at least in some cases default prefs on nightly-only are applied to non-shippable builds. That might be another bug.
Assignee | ||
Comment 47•5 years ago
|
||
Just so I don't lose track of it, this is the baseline for comparisons:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a630530d0bf03f3fe7b8607de22cce3817da9d66
Assignee | ||
Comment 48•5 years ago
|
||
Assignee | ||
Comment 49•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f62570c154bfacfd0f08e20504ea82085880d77
Comment 50•5 years ago
|
||
Thanks for the heads up.. though I'm pretty sure at least the fission case is working (due to there being tons of errors everywhere). Maybe Gecko is stripping off the extra quotes in that case though.
Either way, we might as well fix this in the pref parsing function.
Assignee | ||
Comment 51•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=36fb5ad87372b548d7168b5d2cc35c68bea3b391
Assignee | ||
Comment 52•5 years ago
|
||
Seeing a strange failure in bc9 on OS 10.10 debug. Not sure if that's preexisting, trying to figure that out.
Assignee | ||
Comment 53•5 years ago
|
||
Ok... retriggers are failing here too.
Assignee | ||
Comment 54•5 years ago
|
||
Looks like bug 1459355 is preventing me from retriggering the jobs I need to.
Assignee | ||
Comment 55•5 years ago
|
||
Re-pushing to check out that bc9 failure.
With patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27ad7a69e7d61cfd948d9af66684ec604d0c1345
Without: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b350153705a8df762bb634ea3a18ca02669832b2
Assignee | ||
Comment 56•5 years ago
|
||
Depends on D34885
Assignee | ||
Comment 57•5 years ago
|
||
Depends on D37503
Updated•5 years ago
|
Assignee | ||
Comment 59•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fc4741f9454e8dc853f3d54a2cabc21fb50ad58
Assignee | ||
Comment 60•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6b2d44667a55e738ad2038ba02ff10d1436348c
Assignee | ||
Comment 61•5 years ago
|
||
Assignee | ||
Comment 62•5 years ago
•
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5747981851d4b414478816cc76fe8287a2b9c03 Baseline: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94389c573f1dade90f05608e01f670570d095580
Assignee | ||
Comment 63•5 years ago
|
||
Right. Retriggers are just getting /dev/nulled for that task, apparently. Awesome.
I did see the same failure yesterday on a different bug, so it is probably a pre-existing intermittent.
Now I get to check talos out. Fun.
Assignee | ||
Comment 64•5 years ago
|
||
Assignee | ||
Comment 65•5 years ago
|
||
Retriggering some talos runs. Also, I need to run talos on baseline on try, since talos on try sometimes performs very differently than on m-c.
Assignee | ||
Comment 66•5 years ago
|
||
Assignee | ||
Comment 67•5 years ago
|
||
Talos looks fine.
Comment 68•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9b36f76244b Set the socket-process-isolation prefs to true on nightly. r=mjf https://hg.mozilla.org/integration/autoland/rev/0cb155d5d76a Ensure that the new default values for nightly have no effect on CI. r=ahal https://hg.mozilla.org/integration/autoland/rev/c0e887e7fc78 Update android manifest files to include the socket process. r=snorp https://hg.mozilla.org/integration/autoland/rev/c4e7dc6befff Add --setpref option to many test types r=ahal https://hg.mozilla.org/integration/autoland/rev/8ec55eb4aed6 Disable the socket process if e10s is disabled. r=kershaw
Comment 69•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e9b36f76244b
https://hg.mozilla.org/mozilla-central/rev/0cb155d5d76a
https://hg.mozilla.org/mozilla-central/rev/c0e887e7fc78
https://hg.mozilla.org/mozilla-central/rev/c4e7dc6befff
https://hg.mozilla.org/mozilla-central/rev/8ec55eb4aed6
Description
•