Closed Bug 1555934 Opened 1 year ago Closed 1 year ago

Artifacts in some png images

Categories

(Core :: ImageLib, defect, P2)

69 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 + verified

People

(Reporter: striptm, Assigned: aosmond)

References

(Regression)

Details

(Keywords: regression)

Attachments

(7 files)

In version 69 it can be seen that some images in png format add artefacts/colours that are not real.

Note: These png are generated using the imagick library

Some examples:
http://www.movistarplus.es/recorte/m-NEO/canal/LA2.png
http://www.movistarplus.es/recorte/m-NEO/canal/C4.png

Attached image original file

Tested in Ubuntu 19.04 about:buildconfig

Build Configuration
Source

Built from https://hg.mozilla.org/mozilla-central/rev/e09471d136599b68f40f6bb9ec7fcc419732948e
Build platform
target
x86_64-pc-linux-gnu
Build tools
Compiler Version Compiler flags
/builds/worker/workspace/build/src/clang/bin/clang -std=gnu99 8.0.0 -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -fPIC -pipe
/builds/worker/workspace/build/src/clang/bin/clang++ 8.0.0 -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fno-omit-frame-pointer -funwind-tables
/builds/worker/workspace/build/src/rustc/bin/rustc 1.35.0
Configure options

MOZ_AUTOMATION=1 MOZILLA_OFFICIAL=1 --enable-update-channel=nightly CC=/builds/worker/workspace/build/src/clang/bin/clang CXX=/builds/worker/workspace/build/src/clang/bin/clang++ LLVM_PROFDATA=/builds/worker/workspace/build/src/clang/bin/llvm-profdata --enable-profile-use --with-pgo-profile-path=/builds/worker/fetches --with-pgo-jarlog=/builds/worker/fetches/en-US.log MOZ_LTO=1 NASM=/builds/worker/workspace/build/src/nasm/nasm ENABLE_CLANG_PLUGIN=1 MOZ_STDCXX_COMPAT=1 AR=/builds/worker/workspace/build/src/clang/bin/llvm-ar MOZ_NO_PIE_COMPAT=1 RUSTC=/builds/worker/workspace/build/src/rustc/bin/rustc CARGO=/builds/worker/workspace/build/src/rustc/bin/cargo RUSTDOC=/builds/worker/workspace/build/src/rustc/bin/rustdoc CBINDGEN=/builds/worker/workspace/build/src/cbindgen/cbindgen RUSTFMT=/builds/worker/workspace/build/src/rustc/bin/rustfmt LLVM_CONFIG=/builds/worker/workspace/build/src/clang/bin/llvm-config --enable-js-shell NODEJS=/builds/worker/workspace/build/src/node/bin/node --with-mozilla-api-keyfile=/builds/mozilla-desktop-geoloc-api.key --with-google-location-service-api-keyfile=/builds/gls-gapi.data --with-google-safebrowsing-api-keyfile=/builds/sb-gapi.data --enable-rust-simd MAKE=/usr/bin/make --enable-crashreporter --with-branding=browser/branding/nightly

Perhaps fixed by bug 1555329?

I have tried to activate / deactivate
gfx.color_management.enablev4 and restart the browser.

And the the same result.

Can I try it another way?

Can you run mozregression to pin point when this broke for you?

https://mozilla.github.io/mozregression/

Flags: needinfo?(striptm)

Of course, this is the result:

7:36.88 INFO: application_version: 69.0a1
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): bad
7:45.93 INFO: Narrowed inbound regression window from [c8e48e28, 261cec1f] (4 builds) to [c8e48e28, 44fa7156] (3 builds) (~1 steps left)
7:45.93 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c8e48e2861c5c0a3607f8ea30fbb2a7ee349bf83&tochange=44fa715640dd2a4d06014e6d5fdda63c52707188

7:45.93 INFO: Using local file: /home/fer/.mozilla/mozregression/persist/ca4f3b736dd6-shippable--mozilla-inbound--target.tar.bz2 (downloaded in background)
7:45.93 INFO: Running mozilla-inbound build built on 2019-05-28 13:50:17.285000, revision ca4f3b73
8:08.16 INFO: Launching /tmp/tmpzlql_d/firefox/firefox
8:08.16 INFO: Application command: /tmp/tmpzlql_d/firefox/firefox --allow-downgrade -profile /tmp/tmp6iZlz8.mozrunner
8:08.17 INFO: application_buildid: 20190528120234
8:08.17 INFO: application_changeset: ca4f3b736dd6cbe6e1b195a4800b009ea55bf91d
8:08.17 INFO: application_name: Firefox
8:08.17 INFO: application_repository: https://hg.mozilla.org/integration/mozilla-inbound
8:08.17 INFO: application_version: 69.0a1
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
8:16.30 INFO: Narrowed inbound regression window from [c8e48e28, 44fa7156] (3 builds) to [ca4f3b73, 44fa7156] (2 builds) (~1 steps left)
8:16.30 INFO: No more inbound revisions, bisection finished.
8:16.30 INFO: Last good revision: ca4f3b736dd6cbe6e1b195a4800b009ea55bf91d
8:16.30 INFO: First bad revision: 44fa715640dd2a4d06014e6d5fdda63c52707188
8:16.30 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ca4f3b736dd6cbe6e1b195a4800b009ea55bf91d&tochange=44fa715640dd2a4d06014e6d5fdda63c52707188

Flags: needinfo?(striptm)

Thank you for that.

Sorry, bug 1555329 hadn't landed yet when I posted the comment 3 above. Can you try the latest nightly and see if the problem still happens? The fix for bug 1555329 will be in the latest nightly now.

Flags: needinfo?(striptm)

No, the problem persists as seen in the capture.

My lastest Nightly:
Nombre Firefox
Versión 69.0a1
ID de compilación 20190603101337

Flags: needinfo?(striptm)

Could you attach your display color profile to the bug? From your about:buildconfig, you are using Ubuntu, so I think you can find it under ~/.local/share/icc/.

Flags: needinfo?(striptm)

Additionally, if you try setting gfx.color_management.force_srgb to true in about:config, does it continue to render poorly? The color management profile is the only way I can think of that you would produce consistently differently results than us.

Attached file buildconfig.html
Flags: needinfo?(striptm)

And setting gfx.color_management.force_srgb to true displays the image properly

(In reply to Fernando García Gómez, stripTM from comment #14)

And setting gfx.color_management.force_srgb to true displays the image properly

Thank you, this suggests a bug in QCMS. Possibly something bad I did in bug 1551084...

Assignee: nobody → aosmond
Priority: -- → P2
Regressed by: 1255106

Okay, so I tried running with your color profiles but did not reproduce the issue. Could you please run "xprop -root" on the command line and attach the output to the bug? This will allow me to inspect the values of _ICC_PROFILE, XFree86_DDC_EDID1_RAWDATA and possibly any other relevant properties. If it doesn't match the .icc profiles you attached, then I can at least recreate it from that output and hopefully reproduce this time. Thanks again!

Flags: needinfo?(striptm)

I have tested on 3 different pcs with Ubuntu and the problem I see in 2 of them.

This is the "xprop -root" information of the affected

_MUTTER_SENTINEL(CARDINAL) = 0
_ICC_PROFILE_IN_X_VERSION(CARDINAL) = 3
_ICC_PROFILE(CARDINAL) = 0, 0, 5, 212, 108, 99, 109, 115, 4, 48, 0, 0, 109, 110, 116, 114, 82, 71, 66, 32, 88, 89, 90, 32, 7, 226, 0, 5, 0, 25, 0, 14, 0, 28, 0, 20, 97, 99, 115, 112, 65, 80, 80, 76, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 246, 214, 0, 1, 0, 0, 0, 0, 211, 45, 108, 99, 109, 115, 224, 64, 106, 159, 104, 146, 201, 12, 203, 56, 79, 175, 254, 129, 168, 245, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 14, 100, 101, 115, 99, 0, 0, 1, 44, 0, 0, 0, 50, 99, 112, 114, 116, 0, 0, 1, 96, 0, 0, 0, 134, 119, 116, 112, 116, 0, 0, 1, 232, 0, 0, 0, 20, 99, 104, 97, 100, 0, 0, 1, 252, 0, 0, 0, 44, 114, 88, 89, 90, 0, 0, 2, 40, 0, 0, 0, 20, 98, 88, 89, 90, 0, 0, 2, 60, 0, 0, 0, 20, 103, 88, 89, 90, 0, 0, 2, 80, 0, 0, 0, 20, 114, 84, 82, 67, 0, 0, 2, 100, 0, 0, 0, 16, 103, 84, 82, 67, 0, 0, 2, 100, 0, 0, 0, 16, 98, 84, 82, 67, 0, 0, 2, 100, 0, 0, 0, 16, 99, 104, 114, 109, 0, 0, 2, 116, 0, 0, 0, 36, 109, 101, 116, 97, 0, 0, 2, 152, 0, 0, 2, 214, 100, 109, 110, 100, 0, 0, 5, 112, 0, 0, 0, 46, 100, 109, 100, 100, 0, 0, 5, 160, 0, 0, 0, 50, 109, 108, 117, 99, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 12, 101, 110, 85, 83, 0, 0, 0, 22, 0, 0, 0, 28, 0, 68, 0, 69, 0, 76, 0, 76, 0, 32, 0, 80, 0, 50, 0, 51, 0, 49, 0, 50, 0, 72, 0, 0, 109, 108, 117, 99, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 12, 101, 110, 85, 83, 0, 0, 0, 106, 0, 0, 0, 28, 0, 84, 0, 104, 0, 105, 0, 115, 0, 32, 0, 112, 0, 114, 0, 111, 0, 102, 0, 105, 0, 108, 0, 101, 0, 32, 0, 105, 0, 115, 0, 32, 0, 102, 0, 114, 0, 101, 0, 101, 0, 32, 0, 111, 0, 102, 0, 32, 0, 107, 0, 110, 0, 111, 0, 119, 0, 110, 0, 32, 0, 99, 0, 111, 0, 112, 0, 121, 0, 114, 0, 105, 0, 103, 0, 104, 0, 116, 0, 32, 0, 114, 0, 101, 0, 115, 0, 116, 0, 114, 0, 105, 0, 99, 0, 116, 0, 105, 0, 111, 0, 110, 0, 115, 0, 46, 0, 0, 88, 89, 90, 32, 0, 0, 0, 0, 0, 0, 246, 214, 0, 1, 0, 0, 0, 0, 211, 45, 115, 102, 51, 50, 0, 0, 0, 0, 0, 1, 11, 183, 0, 0, 5, 150, 255, 255, 243, 86, 0, 0, 7, 41, 0, 0, 253, 215, 255, 255, 251, 182, 255, 255, 253, 165, 0, 0, 3, 218, 0, 0, 192, 246, 88, 89, 90, 32, 0, 0, 0, 0, 0, 0, 112, 189, 0, 0, 61, 95, 0, 0, 1, 195, 88, 89, 90, 32, 0, 0, 0, 0, 0, 0, 38, 56, 0, 0, 13, 247, 0, 0, 194, 177, 88, 89, 90, 32, 0, 0, 0, 0, 0, 0, 95, 226, 0, 0, 180, 170, 0, 0, 14, 185, 112, 97, 114, 97, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 51, 51, 99, 104, 114, 109, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 162, 128, 0, 0, 89, 192, 0, 0, 79, 128, 0, 0, 161, 64, 0, 0, 38, 64, 0, 0, 13, 128, 100, 105, 99, 116, 0, 0, 0, 0, 0, 0, 0, 10, 0, 0, 0, 16, 0, 0, 0, 176, 0, 0, 0, 22, 0, 0, 0, 198, 0, 0, 0, 12, 0, 0, 0, 210, 0, 0, 0, 22, 0, 0, 0, 232, 0, 0, 0, 24, 0, 0, 1, 0, 0, 0, 0, 20, 0, 0, 1, 20, 0, 0, 0, 42, 0, 0, 1, 62, 0, 0, 0, 22, 0, 0, 1, 84, 0, 0, 0, 42, 0, 0, 1, 126, 0, 0, 0, 16, 0, 0, 1, 142, 0, 0, 0, 64, 0, 0, 1, 206, 0, 0, 0, 18, 0, 0, 1, 224, 0, 0, 0, 6, 0, 0, 1, 230, 0, 0, 0, 20, 0, 0, 1, 250, 0, 0, 0, 22, 0, 0, 2, 16, 0, 0, 0, 22, 0, 0, 2, 38, 0, 0, 0, 8, 0, 0, 2, 46, 0, 0, 0, 34, 0, 0, 2, 80, 0, 0, 0, 82, 0, 0, 2, 162, 0, 0, 0, 34, 0, 0, 2, 196, 0, 0, 0, 18, 0, 67, 0, 77, 0, 70, 0, 95, 0, 118, 0, 101, 0, 114, 0, 115, 0, 105, 0, 111, 0, 110, 0, 51, 0, 46, 0, 50, 0, 56, 0, 46, 0, 49, 0, 69, 0, 68, 0, 73, 0, 68, 0, 95, 0, 115, 0, 101, 0, 114, 0, 105, 0, 97, 0, 108, 0, 68, 0, 55, 0, 67, 0, 55, 0, 52, 0, 50, 0, 51, 0, 68, 0, 66, 0, 51, 0, 81, 0, 77, 0, 67, 0, 77, 0, 70, 0, 95, 0, 98, 0, 105, 0, 110, 0, 97, 0, 114, 0, 121, 0, 103, 0, 110, 0, 111, 0, 109, 0, 101, 0, 45, 0, 115, 0, 101, 0, 116, 0, 116, 0, 105, 0, 110, 0, 103, 0, 115, 0, 45, 0, 100, 0, 97, 0, 101, 0, 109, 0, 111, 0, 110, 0, 67, 0, 77, 0, 70, 0, 95, 0, 112, 0, 114, 0, 111, 0, 100, 0, 117, 0, 99, 0, 116, 0, 103, 0, 110, 0, 111, 0, 109, 0, 101, 0, 45, 0, 115, 0, 101, 0, 116, 0, 116, 0, 105, 0, 110, 0, 103, 0, 115, 0, 45, 0, 100, 0, 97, 0, 101, 0, 109, 0, 111, 0, 110, 0, 69, 0, 68, 0, 73, 0, 68, 0, 95, 0, 109, 0, 100, 0, 53, 0, 98, 0, 99, 0, 100, 0, 49, 0, 48, 0, 99, 0, 48, 0, 51, 0, 53, 0, 53, 0, 98, 0, 51, 0, 57, 0, 98, 0, 102, 0, 100, 0, 101, 0, 98, 0, 100, 0, 50, 0, 53, 0, 53, 0, 54, 0, 52, 0, 52, 0, 100, 0, 97, 0, 53, 0, 52, 0, 102, 0, 101, 0, 49, 0, 69, 0, 68, 0, 73, 0, 68, 0, 95, 0, 109, 0, 110, 0, 102, 0, 116, 0, 68, 0, 69, 0, 76, 0, 69, 0, 68, 0, 73, 0, 68, 0, 95, 0, 109, 0, 111, 0, 100, 0, 101, 0, 108, 0, 68, 0, 69, 0, 76, 0, 76, 0, 32, 0, 80, 0, 50, 0, 51, 0, 49, 0, 50, 0, 72, 0, 68, 0, 65, 0, 84, 0, 65, 0, 95, 0, 115, 0, 111, 0, 117, 0, 114, 0, 99, 0, 101, 0, 101, 0, 100, 0, 105, 0, 100, 0, 77, 0, 65, 0, 80, 0, 80, 0, 73, 0, 78, 0, 71, 0, 95, 0, 100, 0, 101, 0, 118, 0, 105, 0, 99, 0, 101, 0, 95, 0, 105, 0, 100, 0, 120, 0, 114, 0, 97, 0, 110, 0, 100, 0, 114, 0, 45, 0, 68, 0, 101, 0, 108, 0, 108, 0, 32, 0, 73, 0, 110, 0, 99, 0, 46, 0, 45, 0, 68, 0, 69, 0, 76, 0, 76, 0, 32, 0, 80, 0, 50, 0, 51, 0, 49, 0, 50, 0, 72, 0, 45, 0, 68, 0, 55, 0, 67, 0, 55, 0, 52, 0, 50, 0, 51, 0, 68, 0, 66, 0, 51, 0, 81, 0, 77, 0, 69, 0, 68, 0, 73, 0, 68, 0, 95, 0, 109, 0, 97, 0, 110, 0, 117, 0, 102, 0, 97, 0, 99, 0, 116, 0, 117, 0, 114, 0, 101, 0, 114, 0, 68, 0, 101, 0, 108, 0, 108, 0, 32, 0, 73, 0, 110, 0, 99, 0, 46, 0, 0, 109, 108, 117, 99, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 12, 101, 110, 85, 83, 0, 0, 0, 18, 0, 0, 0, 28, 0, 68, 0, 101, 0, 108, 0, 108, 0, 32, 0, 73, 0, 110, 0, 99, 0, 46, 0, 0, 109, 108, 117, 99, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 12, 101, 110, 85, 83, 0, 0, 0, 22, 0, 0, 0, 28, 0, 68, 0, 69, 0, 76, 0, 76, 0, 32, 0, 80, 0, 50, 0, 51, 0, 49, 0, 50, 0, 72, 0, 0
_NET_ACTIVE_WINDOW(WINDOW): window id # 0x480000a
_NET_CLIENT_LIST_STACKING(WINDOW): window id # 0x580022a, 0x2600007, 0x5c00001, 0x4a00001, 0x4000001, 0x4a00074, 0x22005a8, 0x2200010, 0x2a00003, 0x480000a
_NET_CLIENT_LIST(WINDOW): window id # 0x2200010, 0x2a00003, 0x4000001, 0x480000a, 0x4a00001, 0x580022a, 0x5c00001, 0x2600007, 0x4a00074, 0x22005a8
_NET_CURRENT_DESKTOP(CARDINAL) = 0
PULSE_COOKIE(STRING) = "5a52305ae6ad2903db5e793a4d6af94de5a025d5626b1e25080790b3b13e22af8b48eea3806c09244c897c856b52dfbc6bc9f86a5c5bd41005de8a41be6198e07aaa54476f789a0fdc68de0d7843096c39e11edecce11bea2f6d51e898ecb6c3c105036bd3d9770f72ba68219e32a4b696fab10de59d447d36068de73ff1a3d480cacc4e8503326484a3c5350c344ffec9636c026d86a591d13be08329a840300caccaabf45a0a5b520eaa40e8435a6de5fd77bd51cfb8827e855239d74759fecec9668622bf9cf40f4e021cdd0539b3ba4545ba52c8a6363d29e76586e4d4c3cfbe767b37a753d90d630860d06058111e764ed37516f935c243a750f194577b"
PULSE_SERVER(STRING) = "{320aca9a08cf47e5b29fe40ad77066c7}unix:/run/user/1000/pulse/native"
PULSE_SESSION_ID(STRING) = "2"
PULSE_ID(STRING) = "1000@320aca9a08cf47e5b29fe40ad77066c7/2911"
XIM_SERVERS(ATOM) = @server=ibus
_NET_WORKAREA(CARDINAL) = 70, 27, 2930, 1893, 70, 27, 2930, 1893
_NET_DESKTOP_NAMES(UTF8_STRING) = "Área de trabajo 1"
_NET_SHOWING_DESKTOP(CARDINAL) = 0
_NET_NUMBER_OF_DESKTOPS(CARDINAL) = 2
_NET_DESKTOP_GEOMETRY(CARDINAL) = 3000, 1920
_NET_DESKTOP_VIEWPORT(CARDINAL) = 0, 0
_NET_SUPPORTING_WM_CHECK(WINDOW): window id # 0x600006
_NET_SUPPORTED(ATOM) = _NET_WM_NAME, _NET_CLOSE_WINDOW, _NET_WM_STATE, _NET_WM_STATE_SHADED, _NET_WM_STATE_MAXIMIZED_HORZ, _NET_WM_STATE_MAXIMIZED_VERT, _NET_WM_DESKTOP, _NET_NUMBER_OF_DESKTOPS, _NET_CURRENT_DESKTOP, _NET_WM_WINDOW_TYPE, _NET_WM_WINDOW_TYPE_DESKTOP, _NET_WM_WINDOW_TYPE_DOCK, _NET_WM_WINDOW_TYPE_TOOLBAR, _NET_WM_WINDOW_TYPE_MENU, _NET_WM_WINDOW_TYPE_UTILITY, _NET_WM_WINDOW_TYPE_SPLASH, _NET_WM_WINDOW_TYPE_DIALOG, _NET_WM_WINDOW_TYPE_DROPDOWN_MENU, _NET_WM_WINDOW_TYPE_POPUP_MENU, _NET_WM_WINDOW_TYPE_TOOLTIP, _NET_WM_WINDOW_TYPE_NOTIFICATION, _NET_WM_WINDOW_TYPE_COMBO, _NET_WM_WINDOW_TYPE_DND, _NET_WM_WINDOW_TYPE_NORMAL, _NET_WM_STATE_MODAL, _NET_CLIENT_LIST, _NET_CLIENT_LIST_STACKING, _NET_WM_STATE_SKIP_TASKBAR, _NET_WM_STATE_SKIP_PAGER, _NET_WM_ICON, _NET_WM_ICON_GEOMETRY, _NET_WM_MOVERESIZE, _NET_ACTIVE_WINDOW, _NET_WM_STRUT, _NET_WM_STATE_HIDDEN, _NET_WM_STATE_FULLSCREEN, _NET_WM_PING, _NET_WM_PID, _NET_WORKAREA, _NET_SHOWING_DESKTOP, _NET_DESKTOP_LAYOUT, _NET_DESKTOP_NAMES, _NET_WM_ALLOWED_ACTIONS, _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_STICK, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_STATE_ABOVE, _NET_WM_STATE_BELOW, _NET_STARTUP_ID, _NET_WM_STRUT_PARTIAL, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MINIMIZE, _NET_FRAME_EXTENTS, _NET_REQUEST_FRAME_EXTENTS, _NET_WM_USER_TIME, _NET_WM_STATE_DEMANDS_ATTENTION, _NET_MOVERESIZE_WINDOW, _NET_DESKTOP_GEOMETRY, _NET_DESKTOP_VIEWPORT, _NET_WM_USER_TIME_WINDOW, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW, _NET_WM_STATE_STICKY, _NET_WM_FULLSCREEN_MONITORS, _NET_WM_STATE_FOCUSED, _NET_WM_BYPASS_COMPOSITOR, _NET_WM_OPAQUE_REGION, _NET_WM_FRAME_DRAWN, _NET_WM_FRAME_TIMINGS, _NET_WM_WINDOW_OPACITY, _NET_RESTACK_WINDOW, _GTK_FRAME_EXTENTS, _GTK_SHOW_WINDOW_MENU, _GTK_EDGE_CONSTRAINTS
WM_ICON_SIZE(CARDINAL):
minimum icon size: 32 by 32
maximum icon size: 32 by 32
incremental size change: 0 by 0
XFree86_DDC_EDID1_RAWDATA(INTEGER) = 0, -1, -1, -1, -1, -1, -1, 0, 16, -84, 118, 64, 77, 81, 51, 66, 11, 22, 1, 3, 14, 51, 29, 120, -22, -71, 101, -94, 89, 79, -95, 38, 13, 80, 84, -91, 75, 0, 113, 79, -127, -128, -47, -64, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 58, -128, 24, 113, 56, 45, 64, 88, 44, 69, 0, -2, 31, 17, 0, 0, 30, 0, 0, 0, -1, 0, 68, 55, 67, 55, 52, 50, 51, 68, 66, 51, 81, 77, 10, 0, 0, 0, -4, 0, 68, 69, 76, 76, 32, 80, 50, 51, 49, 50, 72, 10, 32, 0, 0, 0, -3, 0, 56, 76, 30, 83, 17, 0, 10, 32, 32, 32, 32, 32, 32, 0, -17
_GNOME_SESSION_RENDERER(STRING) = "AMD CEDAR (DRM 2.50.0 / 5.0.0-15-generic, LLVM 8.0.0)"
_GNOME_MAX_SCREEN_SIZE(CARDINAL) = 16384
_GNOME_SESSION_ACCELERATED(CARDINAL) = 1
AT_SPI_BUS(STRING) = "unix:abstract=/tmp/dbus-bryp7Pwzsp,guid=d44e79d1edb2c66a0be41db85cf61ef2"
GDK_VISUALS(INTEGER) = 832, 1250
RESOURCE_MANAGER(STRING) = "*customization:\t-color\nXft.dpi:\t96\nXft.antialias:\t1\nXft.hinting:\t1\nXft.hintstyle:\thintslight\nXft.rgba:\trgb\nXcursor.size:\t24\nXcursor.theme:\tYaru\n"
_XKB_RULES_NAMES(STRING) = "evdev", "pc105", "es,es", ",", ""
XFree86_has_VT(INTEGER) = 1
XFree86_VT(INTEGER) = 2

Flags: needinfo?(striptm)

Affected computer 1 - graphics card: AMD® Cedar
Affected computer 2 - graphics card: Intel® Sandybridge Desktop
Graphics card not affected computer: Intel® Ironlake Mobile

Okay, I managed to reproduce once briefly, although not again. I stepped through the decoding before and after the change, as I could see differences in the output, even without seeing the purple distortion in your screenshots. Premultiplication is something that was done after color management which is now done before, and seems to be causing important differences. I actually change this again in my latest performance patches (I wanted it after color management, but it was complicated to get there in one patch set), so maybe I should break out that separately. I will produce a build with just that, and ask you to verify whether or not that fixes your problem.

Otherwise, the image is not very complicated. The surface filter pipeline before my change was just write to the surface directly, no interlacing/interpolation/downscaling/etc. After my change, it is just color management/write to surface. With this next change it will be color management/premultiply/write to surface.

Great, I won't be available until Monday the 17th.

(In reply to Fernando García Gómez, stripTM from comment #21)

Great, I won't be available until Monday the 17th.

That's okay. There are some other reporters with similar issues that I will ask :). Your help thus far has been much appreciated.

I can now reproduce myself with my native color profile on https://lando.services.mozilla.com. The lando logo has a green aura around it, where it did not before.

Yes, the same problem.

Let's do a partial backout to fix things while I try to sort this out. If my understanding of the problem is correct, it should only affect images that have transparency, so the changes may be left in for the JPG decoder. I'll land if/when the try comes back green.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=834ebe814aaf724a0a4a0b32efc26c6568faa77c

Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f493b1b18cf
Partially backout bug 1255106 part 3 to fix decoders with transparency. r=aosmond
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Duplicate of this bug: 1557239
Duplicate of this bug: 1557156

Verified, it's working properly.
Thank you.

Updating flags.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.