JSObject finalizers should use FreeOp methods to free memory
Categories
(Core :: JavaScript: GC, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(2 files)
The idea is that finalizers should not call js_delete/js_free but use the delete_/free_ methods on the FreeOp passed to do this. There are a couple of places this happens though.
Fixing these makes it easier for me to find code to update for bug 1395509.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Carrying on from the last patch, there is one place where we use FreeOp unnecessarily when we're not finalizing.
Depends on D33276
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fdb574e1fca6 Make JSObject finalizers use the FreeOp::delete_/free_ methods r=pbone? https://hg.mozilla.org/integration/autoland/rev/d361c289aaa9 Remove some unnecessary use of FreeOp where plain old js_delete will do r=pbone?
|
||
Comment 4•5 years ago
|
||
Backed out 3 changesets (bug 1395509, bug 1555935) for causing build busateges CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/176ac3f06690a9e5071028ec601a2e743545d045
Log failure https://treeherder.mozilla.org/logviewer.html#?job_id=249693971&repo=autoland
Jon can you please take a look?
|
||
Updated•5 years ago
|
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9242f6f35c85 Make JSObject finalizers use the FreeOp::delete_/free_ methods r=pbone https://hg.mozilla.org/integration/mozilla-inbound/rev/ac87f5dc79e9 Remove some unnecessary use of FreeOp where plain old js_delete will do r=pbone
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9242f6f35c85
https://hg.mozilla.org/mozilla-central/rev/ac87f5dc79e9
|
|
Assignee | |
Updated•5 years ago
|
Description
•