HTMLLinkElement::BindToTree localization code uses uncomposed doc in BindToTree, but composed doc in AfterSetAttr.
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file, 1 obsolete file)
One of those two is necessarily wrong.
|
Assignee | |
Comment 1•5 years ago
|
||
Zibi, do you know if these links are supposed to work in shadow trees or such? If not they should use uncomposed doc.
|
||
Updated•5 years ago
|
|
|
||
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Comment 3•5 years ago
•
|
||
(wrong bug)
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 4•5 years ago
|
||
re-adding needinfo for comment #1 which was mistakenly removed
|
|
||
Updated•5 years ago
|
|
||
Comment 5•5 years ago
•
|
||
I talked with Emilio and Zibi and it's basically unclear, but it probably would not break anything if we disabled this inside shadow trees. So I suggest we do that and only make that work once there's a design as that is how we approach integration of most features with shadow trees.
Axel, I see you're already copied, if you feel strongly in the other direction for some reason please say so and we can reconsider.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
TBH, I can't map the technical terms here to practical behavior.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Nah, the current behavior is just borked, so I don't think it'll break anything. All our current code already puts the link inside the document from what I can tell.
|
|
Assignee | |
Comment 9•5 years ago
|
||
|
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41278b421184 Be consistent in using composed / uncomposed doc for <link rel=localization>. r=smaug
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
Description
•