Closed Bug 1555947 Opened 1 year ago Closed 10 months ago

HTMLLinkElement::BindToTree localization code uses uncomposed doc in BindToTree, but composed doc in AfterSetAttr.

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file, 1 obsolete file)

One of those two is necessarily wrong.

Zibi, do you know if these links are supposed to work in shadow trees or such? If not they should use uncomposed doc.

Flags: needinfo?(gandalf)
Summary: HTMLLinkElement::BindToTree uses uncomposed doc in BindToTree, but composed doc in AfterSetAttr. → HTMLLinkElement::BindToTree localization code uses uncomposed doc in BindToTree, but composed doc in AfterSetAttr.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #9072902 - Attachment description: Bug 1555947 - Use composed doc when with localization in HTMLLinkElement. r?emilio → Bug 1555947 - Use uncomposed doc or shadow root when with localization in HTMLLinkElement. r?emilio

(wrong bug)

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Flags: needinfo?(gandalf)
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee: jaws → nobody
Status: REOPENED → NEW

re-adding needinfo for comment #1 which was mistakenly removed

Flags: needinfo?(gandalf)
Attachment #9072902 - Attachment is obsolete: true

I talked with Emilio and Zibi and it's basically unclear, but it probably would not break anything if we disabled this inside shadow trees. So I suggest we do that and only make that work once there's a design as that is how we approach integration of most features with shadow trees.

Axel, I see you're already copied, if you feel strongly in the other direction for some reason please say so and we can reconsider.

Flags: needinfo?(gandalf) → needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)

TBH, I can't map the technical terms here to practical behavior.

Nah, the current behavior is just borked, so I don't think it'll break anything. All our current code already puts the link inside the document from what I can tell.

Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41278b421184
Be consistent in using composed / uncomposed doc for <link rel=localization>. r=smaug
Status: NEW → RESOLVED
Closed: 1 year ago10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.