Closed Bug 1555987 Opened 6 years ago Closed 6 years ago

Right-clicked source tree item does not appear selected.

Categories

(DevTools :: Debugger, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: janelledement, Unassigned)

Details

Attachments

(3 files)

Attached image nightly-right-click.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

Steps to reproduce:

  1. Navigate to any page and open the debugger.
  2. Right click on any source tree item.

Actual results:

While the context menu is shown to the user, the item itself does not appear selected.

Note: If the user had previously clicked on another item in the sources tree (regular click), that item continues to appear selected even though another item was right clicked afterwards.

Expected results:

When a user right clicks on any item in sources tree, that item should appear as selected as well as showing the context menu. This is the behavior in chrome sources.

Attached image chrome-right-click.jpg
Type: defect → enhancement

@Harald: WDYT? Should an item be selected if only right clicked? E.g. Network panel doesn't select on right click, the Inspector does, Chrome doesn't.

Honza

Flags: needinfo?(hkirschner)

With the recent patch to add hover state to the elements, should we consider this fixed?

I would not treat right-click as click that selects elements, but rather revisit our elements' ":active" state.

Flags: needinfo?(hkirschner)

I agree, closing

@Anyone: let me know if you think this shouldn't be closed.

Honza

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: