1556030 - JavaScript strict warning: chrome://messenger/content/preferences/cookies.js, line 527: ReferenceError: reference to undefined property "QueryInterface"

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

JavaScript strict warning: chrome://messenger/content/preferences/cookies.js, line 527: ReferenceError: reference to undefined property "QueryInterface"

Strange, there is no QI at that line:
https://searchfox.org/comm-central/rev/d3a0f4232bb7b703258d7687572f7ade075c6401/mail/components/preferences/cookies.js#527

This shows in the debug console when pressing "Show Cookies" in the Privacy options.

Aceman, can you see what's going on here?

Comment 1

[:aceman]

Attachment: 1556030.patch

Yes I can see the error in console.
This patch fixes it for me. It seems to me it produces the same result, just without the QI error.
Also other places in the file use this._view directly.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9070394 [details] [diff] [review]
1556030.patch

Review of attachment 9070394 [details] [diff] [review]:
-----------------------------------------------------------------

Any idea where the QI interface errors comes from?

::: mail/components/preferences/cookies.js
@@ +37,5 @@
>    },
>  
>    _populateList(aInitialLoad) {
>      this._loadCookies();
>      this._tree.view = this._view;

Do you still need this assignment? And the one at line 753?

Comment 3

[:aceman]

(In reply to Jorg K (GMT+2) from comment #2)

Any idea where the QI interface errors comes from?

No, I don't know.

::: mail/components/preferences/cookies.js

_populateList(aInitialLoad) {
this._loadCookies();
this._tree.view = this._view;
Do you still need this assignment? And the one at line 753?

Yes, these are needed otherwise the whole dialog breaks.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9070394 [details] [diff] [review]
1556030.patch

Geoff, do you have an opinion here? cookies.js no longer exists in M-C, but it's there in m-esr60 with the lines Aceman is proposing to change now:
https://dxr.mozilla.org/mozilla-esr60/source/browser/components/preferences/cookies.js#50
https://dxr.mozilla.org/mozilla-esr60/source/browser/components/preferences/cookies.js#544

Comment 5

[Geoff Lankow (:darktrojan) [away until April 11]]

I think gCookiesWindow._view should have a QueryInterface function (to nsITreeView, I guess) and that's what the error's complaining about.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9070394 [details] [diff] [review]
1556030.patch

Let's see whether Geoff's suggestion from comment #5 helps.

Comment 7

[:aceman]

Attachment: 1556030.patch v2

Yes, that seems to work too, thanks.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073917 [details] [diff] [review]
1556030.patch v2

Thanks, works for me.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3004cd1a0a75
add QI to nsITreeView for cookie view to stop JS warning. r=jorgk

Comment 10

[Jorg K (CEST = GMT+2)]

TB 68 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/4396446677599c7c565fd29878551e4aa4435870