1556040 - signature generation updates broke siggen

Status: RESOLVED INVALID

(Socorro :: Signature, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Siggen doesn't work in a couple of ways as detailed here:

https://github.com/willkg/socorro-siggen/issues/37

$ cat foo.json | /tmp/venv3/bin/signify 
Traceback (most recent call last):
  File "/tmp/venv3/bin/signify", line 10, in <module>
    sys.exit(main())
  File "/tmp/venv3/lib/python3.7/site-packages/siggen/cmd_signify.py", line 27, in main
    generator = SignatureGenerator(debug=args.verbose)
TypeError: __init__() got an unexpected keyword argument 'debug'

and

$ cat foo.json | /tmp/venv3/bin/signify 
Traceback (most recent call last):
  File "/tmp/venv3/bin/signify", line 10, in <module>
    sys.exit(main())
  File "/tmp/venv3/lib/python3.7/site-packages/siggen/cmd_signify.py", line 33, in main
    print(json.dumps(ret, indent=2))
  File "/usr/lib/python3.7/json/__init__.py", line 238, in dumps
    **kw).encode(obj)
  File "/usr/lib/python3.7/json/encoder.py", line 201, in encode
    chunks = list(chunks)
  File "/usr/lib/python3.7/json/encoder.py", line 438, in _iterencode
    o = _default(o)
  File "/usr/lib/python3.7/json/encoder.py", line 179, in default
    raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type Result is not JSON serializable

Since siggen is extracted from Socorro, I think we need to fix them in Socorro first, then do another extraction.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Scratch that--both are fixed in a command that only exists in siggen. Marking as INVALID.