1556050 - Keep the login-list header visible while scrolling the logins

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The header for the login list on about:logins with sorting options and the number of visible logins should remain visible while scrolling the list.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1556050 - Keep the login-list header visible while scrolling the list. r?_6a68

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e1df6e707e7
Keep the login-list header visible while scrolling the list. r=_6a68

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0e1df6e707e7

Comment 4

[Timea Cernea [:tbabos][inactive]]

Attachment: Dark OS opacity issue

Verified-Fixed on Windows 7/10, Mac OS 10.14 and Ubuntu 18.04.
Please note that on Windows if the Dark default app mode is enabled, the login-list header will have improper opacity, check the attached screenshot.
Otherwise, the header is visible while scrolling the list.

On Ubuntu the distance between the scrollbar and the header could be improved as the gap between the mentioned elements is too big when the scrollbar is not focused, check: https://imgur.com/a/a69xM7m

Comment 5

[Timea Cernea [:tbabos][inactive]]

Closing this as Verfiied - Fixed.
Jared, please let me know if I should submit the above-mentioned issues.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Timea Babos from comment #5)

Closing this as Verfiied - Fixed.
Jared, please let me know if I should submit the above-mentioned issues.

Hi Timea, yes can you please file those issues? Thanks for finding them!

Comment 7

[Timea Cernea [:tbabos][inactive]]

Thanks!
Submitted: Bug 1556965 and Bug 1556973