Closed Bug 1556056 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17120 - [css-flexbox] Don't set height to 0 before ForceLayout

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17120 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17120
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[css-flexbox] Don't set height to 0 before ForceLayout

It's not necessary and causes problems in LayoutNG when we reuse the
cached fragment inside of ForceLayout (nothing will set the height
to the correct value)

In the specific testcase, we incorrectly think that the block has a
percentage-sized child due to the abspos item.

Bug: 967061
Change-Id: If6fabc93173f025966f359510e5b600914376e45
Reviewed-on: https://chromium-review.googlesource.com/1638192
WPT-Export-Revision: 8f504a1baee791c736b61720904af5a2b2a6a252

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f40f67ccf72
[wpt PR 17120] - [css-flexbox] Don't set height to 0 before ForceLayout, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8f40f67ccf72

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream error] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.