1556079 - [webvtt] enable wpt 'cue_too_long.html'.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alastor Wu [:alwu]]

This reference file uses wrong text, which causes failure.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1556079 - part2 : enable and modify wpt 'cue_too_long.html'.

Use correct text in reference file and use WebVTT's default text sans-serif for the comparison.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1556079 - part1 : hide cue if we can't find a good place to put it fully inside the rendering area.

According to the spec 7.2.10.17 [1], if we have tried both direction and there is no place to put the cue inside the rendering area without overlapping with other cues or the boundary of rendering area, then we have to discard all CSS boxes, which means that we should not display this cue.

[1] https://www.w3.org/TR/webvtt1/#processing-cue-settings

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7c18cfb94b3
part1 : hide cue if we can't find a good place to put it fully inside the rendering area. r=heycam

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for assertion failures at parserWrapper.

Backout link: https://hg.mozilla.org/integration/autoland/rev/62ffe9bbae2ebdf9b31655e0c3b07335ea2f4757
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=251763646&revision=a7c18cfb94b3846a25a130c60e45552dc9884a72
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251763646&repo=autoland&lineNumber=1779

Comment 5

[Narcis Beleuzu [:NarcisB]]

There were also xpcshell failures on test_parser.js
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251763637&repo=autoland&lineNumber=2446

Comment 6

[Narcis Beleuzu [:NarcisB]]

Also crashes on [@ mozilla::dom::TextTrackManager::TextTrackManager(mozilla::dom::HTMLMediaElement*)]
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251769356&repo=autoland&lineNumber=4040

Comment 7

[Alastor Wu [:alwu]]

Sorry, that was caused by my rebasing error. It has been fixed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba6b70722629
part1 : hide cue if we can't find a good place to put it fully inside the rendering area. r=heycam
https://hg.mozilla.org/integration/autoland/rev/929d55b41980
part2 : enable and modify wpt 'cue_too_long.html'. r=heycam

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ba6b70722629
https://hg.mozilla.org/mozilla-central/rev/929d55b41980

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18200 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/18200
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/XjOgXP88R4yxfKOZ1BAEkQ)

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged