Closed Bug 1556080 Opened 5 years ago Closed 5 years ago

Fix |Tools > Developer Tools > Error Console| - Click on JS file link (2019 version)

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird68+ fixed, thunderbird69 fixed)

VERIFIED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 + fixed
thunderbird69 --- fixed

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1454041 +++
+++ This bug was initially created as a clone of Bug #1439021 +++

This is broken again :-(

This time we get:
TypeError: this.gViewSourceUtils is undefined webconsole.js:168:5

Geoff, I believe you fixed this various times, so can you do it again.

Setting pref view_source.editor.external and view_source.editor.path doesn't help this time.

Flags: needinfo?(geoff)

It works fine for me.

Flags: needinfo?(geoff)

Really? I tried TB 68 beta (downloaded from treeherder) on various profiles and get
TypeError: this.gViewSourceUtils is undefined webconsole.js:168:5
all the time. I'm talking about the browser/error console.

EDIT: Not working, even on a completely new profile.

Works fine on a local trunk build. There were issues in the past where server builds and local builds behaved differently, see for example bug 1454041 comment #2 and further down around cmt 27 +/- 4 comments up and down.

Flags: needinfo?(geoff)
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9069553 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9069553 [details] [diff] [review]
1556080-view-source-1.diff

I'm stealing this to try it on the server right now.
Attachment #9069553 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9069553 - Flags: approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cd98a2947dd2
Add gViewSourceUtils object to Error Console window. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0

Works on server build, off to beta, thanks Geoff!!

Status: RESOLVED → VERIFIED

Working in beta, too :-)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: