1556093 - Perma browser_partitionedLocalStorage_events.js | Undefined value! - "tracker-0.3787650295256073" == "undefined" - | localStorage data was cleared - got true, expected false - when Gecko 69 merges to Beta on 2019-07-01

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Cosmin Sabou [:CosminS]]

[Tracking Requested - why for this release]:

central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=073df4aa87c5ae9d2cf2432e0435e772e7baf7ff&searchStr=mochitest&selectedJob=249377829

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249377829&repo=try&lineNumber=5177
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249371341&repo=try&lineNumber=32991

looks to be a fallout from https://bugzilla.mozilla.org/show_bug.cgi?id=1555564. Ehsan, would you please take a look?

Comment 1

[Intermittent Failures Robot]

34 failures in 155 pushes (0.219 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 34

Platform breakdown:

• linux64: 4
• linux64-qr: 1
• android-em-7-0-x86_64: 2
• macosx1010-64: 2
• windows7-32: 2
• macosx1010-64-devedition: 2
• macosx1010-64-shippable: 2
• windows10-64: 2
• windows10-64-qr: 2
• windows7-32-devedition: 2
• windows10-64-shippable: 2
• windows10-64-shippable-qr: 2
• linux64-shippable: 2
• linux64-shippable-qr: 1
• linux64-devedition: 2
• windows7-32-shippable: 2
• windows10-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556093&startday=2019-06-01&endday=2019-06-01&tree=all

Comment 2

[Intermittent Failures Robot]

36 failures in 4337 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 36

Platform breakdown:

• windows10-64: 3
• linux64: 5
• linux64-qr: 1
• android-em-7-0-x86_64: 2
• macosx1010-64: 2
• windows7-32: 2
• macosx1010-64-devedition: 2
• macosx1010-64-shippable: 2
• windows10-64-qr: 2
• windows7-32-devedition: 2
• windows10-64-shippable: 2
• windows10-64-shippable-qr: 2
• linux64-shippable: 2
• linux64-shippable-qr: 1
• linux64-devedition: 2
• windows7-32-shippable: 2
• windows10-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556093&startday=2019-05-27&endday=2019-06-02&tree=all

Comment 3

[(no longer active)]

There are at least two problems happening here, perhaps even more.

One is bug 1555562 which Nihanth is working on. The other is that here https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/dom/storage/LocalStorageManager.cpp#245 we use aPrincipal rather than aStoragePrincipal and this is used to construct a PBackgroundLocalStorageCache actor but with the wrong principal, and later on this actor will send a storage change notification back to the content process which will have the wrong principal attached to it: https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/dom/storage/StorageIPC.cpp#84

Perhaps there would be more to fix after fixing these...

Comment 4

[(no longer active)]

Attachment: Bug 1556093 - Use the storage principal when constructing a PBackgroundLocalStorageCache actor;

Comment 5

[Oana Pop-Rus]

This fail still appears on late beta sims push: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=c2d8fe0f14155a85e80e13e21bee8867356ca027&searchStr=mochitest&selectedJob=249920994

Another example of failure from today: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=c2d8fe0f14155a85e80e13e21bee8867356ca027&selectedJob=249922446&searchStr=a783c28f27c68d74aa877554b357a28b3f30b46b

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The beta sim push was with the patch applied: https://hg.mozilla.org/try/rev/0c598afb00d72ad2aebe2ee3097d8e7a7e233de3

Comment 7

[(no longer active)]

(In reply to Oana Pop-Rus from comment #5)

This fail still appears on late beta sims push: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=c2d8fe0f14155a85e80e13e21bee8867356ca027&searchStr=mochitest&selectedJob=249920994

Yes, there is no need for updates here, thanks! I will post a comment when the bug is fixed so that you can verify that.

Another example of failure from today: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=c2d8fe0f14155a85e80e13e21bee8867356ca027&selectedJob=249922446&searchStr=a783c28f27c68d74aa877554b357a28b3f30b46b

That failure (and also whatever comment 1 and comment 2 are pointing to) have nothing to do with this bug whatsoever and should be filed separately. (I haven't even looked at it.)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52ffeb5aaab2
Use the storage principal when constructing a PBackgroundLocalStorageCache actor; r=baku

Comment 9

[(no longer active)]

(In reply to :Ehsan Akhgari from comment #3)

There are at least two problems happening here, perhaps even more.

One is bug 1555562 which Nihanth is working on. The other is that here https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/dom/storage/LocalStorageManager.cpp#245 we use aPrincipal rather than aStoragePrincipal and this is used to construct a PBackgroundLocalStorageCache actor but with the wrong principal, and later on this actor will send a storage change notification back to the content process which will have the wrong principal attached to it: https://searchfox.org/mozilla-central/rev/f8b11433159cbc9cc80500b3e579d767473fa539/dom/storage/StorageIPC.cpp#84

Perhaps there would be more to fix after fixing these...

The only two parts needed here are these which are both on autoland right now. After those fixes, bug 1556812 is still left which I will look into next.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/52ffeb5aaab2

Comment 11

[Alexandru Michis [:malexandru]]

Still happening in today's beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=adc615b23d058a356988dab630b01fc87cc3a438&searchStr=%285%29&selectedJob=250164282

Comment 12

[(no longer active)]

(In reply to Alexandru Michis [:malexandru] from comment #11)

Still happening in today's beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=adc615b23d058a356988dab630b01fc87cc3a438&searchStr=%285%29&selectedJob=250164282

Two questions:

1. Why is this changeset included in that try push? It hasn't landed yet, and it was never tested by me. I don't know what its impact on this test is...

2. Did that push include the fix to bug 1555562?

Since I cannot reproduce this bug any more, the reason why you are seeing it most likely goes back to one of these...

Comment 13

[(no longer active)]

(In reply to :Ehsan Akhgari from comment #12)

(In reply to Alexandru Michis [:malexandru] from comment #11)

Still happening in today's beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=adc615b23d058a356988dab630b01fc87cc3a438&searchStr=%285%29&selectedJob=250164282

Two questions:

1. Why is this changeset included in that try push? It hasn't landed yet, and it was never tested by me. I don't know what its impact on this test is...

FWIW I just tested this changeset locally and it has no impact on whether this test passes or fails thankfully, so this is probably not the cause.

Comment 14

[(no longer active)]

Hmm, https://hg.mozilla.org/try/file/adc615b23d058a356988dab630b01fc87cc3a438/dom/interfaces/storage/nsIDOMStorageManager.idl shows that the push also had the fix for bug 1555562...

And then I looked more carefully at the try push and I saw that the failures are in a whole different test: test_ext_storage_cleanup.html which I don't know anything about. Could you maybe file a separate bug on that and CC the right people who have in the past changed that test? Thanks!

Comment 15

[Andreea Pavel [:apavel]]

Ehsan, hello. The initial failures here are in test_ext_storage_cleanup.html as the bug was filed: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249377829&repo=try&lineNumber=5160

Sorry if I did not understand your last comment. Could you please clarify?

Comment 16

[(no longer active)]

(And to be more clear about what happened in this bug, the original failures were in both browser_partitionedLocalStorage_events.js which I know about and test_ext_storage_cleanup.html which I know nothing about and it seems like now the former is fixed and we only have the latter left to fix, I was suggesting to move that to another bug since that's probably unrelated to this.)

Comment 17

[(no longer active)]

(In reply to Andreea Pavel [:apavel] from comment #15)

Ehsan, hello. The initial failures here are in test_ext_storage_cleanup.html as the bug was filed: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249377829&repo=try&lineNumber=5160

Sorry if I did not understand your last comment. Could you please clarify?

Sorry I mid-aired, comment 16 is explaining what happened here. :-) It is probably worth bisecting that failure separately too (I haven't really investigated it at all.)

Comment 18

[Intermittent Failures Robot]

3 failures in 5197 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform breakdown:

• linux64: 1
• windows10-64-qr: 1
• linux64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556093&startday=2019-06-03&endday=2019-06-09&tree=all