1556210 - Regression, JS shell crashes on macOS, "Assertion failure: gInitialized (calling TimeDuration too early)"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Philip Chimento [:ptomato]]

See bug 1414945 for description, this is basically the same thing, but newly regressed in bug 1505622.

Comment 1

[Philip Chimento [:ptomato]]

Attachment: Bug 1556210 - Don't use TimeDuration in static initializer. r?jandem

On Darwin this would cause a race between two static initializers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d9ce93eacf6
Don't use TimeDuration in static initializer. r=jonco

Comment 3

[Philip Chimento [:ptomato]]

This doesn't need an uplift request yet, if I want to get it into esr68, correct?

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7d9ce93eacf6

Comment 5

[Philip Chimento [:ptomato]]

Comment on attachment 9069208 [details]
Bug 1556210 - Don't use TimeDuration in static initializer. r?jandem

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This affects embedders of SpiderMonkey on macOS. The crash makes it impossible to run any application with embedded SpiderMonkey if using ESR68.
• User impact if declined: Embedders of SpiderMonkey will have to patch ESR68 themselves, or stick with ESR60.
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A patch with a very similar fix (bug 1414945) was uplifted to a previous ESR without incident. Since the change involves static initializers, any problems will probably be immediately obvious.
• String or UUID changes made by this patch: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9069208 [details]
Bug 1556210 - Don't use TimeDuration in static initializer. r?jandem

68 is still on Beta, so let's start there with the approval request.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9069208 [details]
Bug 1556210 - Don't use TimeDuration in static initializer. r?jandem

approved for 68.0b10

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8a4c14d86baa