155624 - Toolbar item state is updated every mouse move in the browser window

Status: RESOLVED WONTFIX

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Simon Fraser [no longer active]]

If you put an NSLog in validateToolbarItem in BrowserWindowController, you'll
see that it gets called for every mouse move in the browser window, which seems
like overkill, and could hurt performance. Automatic updating is supposed to
happen on 'every user event' according to the docs, but to do it on mouse move
seems extreme. We might have to move to manual item updating.

Comment 1

[Simon Fraser [no longer active]]

This is probably why:

    [[self window] setAcceptsMouseMovedEvents: YES];

Comment 2

[Max Horn]

This is "normal" behaviour as can be easily verified by modifying the SimpleToolbar 
example project (I consider it more like a bug/misfeature in NSToolbar, but in any case, it 
is not Chimera's fault).

As a consequence, one has to make sure that validateToolbarItem is implemented in a 
efficient way (I did so for my own projects), e.g. by caching the information. I looked at 
your validateToolbarItem, but since I don't know to much about Chimera's inner working, I 
can't judge how "efficient" the current code is.

Comment 3

[Mike Pinkerton (not reading bugmail)]

is there anything at all we can do about this? subclass the toolbar so that it
doesn't do it? we seem to force validation when we need to manually anyway.

Comment 4

[Richard Schreyer]

Automatic toolbar validation is really nice from a development standpoint.  I'd
like to keep it this way, if we can limit the events it validates with.

While in my programs I've cached the info necessary to create a toolbar item
(namely, the image), caching the enabled state is no better than just telling
the toolbar to update manually, since we'll need to activly mark one or the
other as invalid, either way.

I'll look further into this.

Comment 5

[Simon Fraser [no longer active]]

Can we restrict mouse moves to the content rect, rather than the entire window?

Comment 6

[Richard Schreyer]

After running it through Sampler, I don't think this is an issue at all.  The
validateToolbarItems method is really efficent, and the time spent in it is
insignificant compared to mozilla's mouseMoved actions.

Comment 7

[Jasper]

Mike could you take a look at this?

Comment 8

[Samuel Sidler (old account; do not CC)]

Ping.

Mike, Simon, can someone look at this?

Comment 9

[Chris Lawson (gone)]

Per comment 6, is this even worth bothering with any more?

Comment 10

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]