1556332 - `moz-phab patch` should not prompt to apply abandoned children

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Mark Banner (:standard8)]

I just tried moz-phab patch D32565 and got:

$ moz-phab patch --apply-to here D32565
Revision D32565 has child(ren).  Would you like to patch the full stack?. (YES/No/Always)?

I was confused as I didn't know it had children, looking at phabricator, the child is D32748 and is marked as abandoned.

I don't think we should be trying to apply abandoned patches, if they're in the stack - or maybe we should allow an option to apply abandoned patches (for picking up an old stack), or at least be explicit that they're abandoned.

Comment 1

[:glob ✱]

Attachment: Bug 1556332: ignore abandoned revisions when applying patches; r=zalun

Comment 2

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/411ac5acc100bb9dccbfdea86887efc214943721