Closed Bug 1556345 Opened 5 years ago Closed 5 years ago

Various telemetry tidyups

Categories

(Core :: JavaScript: GC, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(3 files)

There's a few things I'd like to tidy up concerning GC telemetry.

I'm not sure how this used to work but I'm pretty sure it doesn't any more. This changes us to use a single defintion of whether we're animating everywhere.

GC_NURSERY_BYTES_2 was introduce a while ago and should replace the original histogram. Set the expiry for three versions time. Also ensures the dev-telemetry-gc-alerts email is attached to all GC telememtry.

Depends on D33663

We can only reset one slice per GC, as a reset finishes the GC non-incrementally. Change the telemetry to report reset per-GC rather than per-slice as this can suggest the rate of resets is lower than it really is.

Depends on D33664

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e6f34131868
Make slice length during anmiation telemetry use the same definition of whether we are animating as everywhere else r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/67a9ba78a7fe
Slate GC_NURSERY_BYTES telementry for expiry r=chutten
https://hg.mozilla.org/integration/mozilla-inbound/rev/393ea9320fc2
Report reset telemetry per GC, not per slice r=sfink
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: