Closed Bug 1556380 Opened 3 years ago Closed 2 years ago

[meta] Enable more ESLint rules for extensions/

Categories

(Core :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox69 --- wontfix
firefox73 --- fixed

People

(Reporter: standard8, Assigned: meghaaa)

References

(Blocks 1 open bug)

Details

(Keywords: meta, Whiteboard: [lang=js])

Attachments

(1 file)

In bug 1554121 we enabled ESLint for various directories in extensions/, however we also disabled various rules. Now that bug has landed, we should work to enable the rules that were initially disabled.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build (an artifact build is sufficient).
  3. Start working on this bug.
  4. Build your change with mach build and test your change with:
    • ./mach xpcshell-test extensions
    • ./mach mochitest extensions
  5. Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Can i work on this?

Hi Melvin, yes that's fine, I've assigned it to you. Just one note, when you submit the patch, do you mind trying to not have your name as all-caps? We generally don't do that for submissions.

Assignee: nobody → melvingeorge10

Is there a better component for this bug?

Flags: needinfo?(standard8)

(In reply to Andrew Overholt [:overholt] from comment #3)

Is there a better component for this bug?

This covers permission manager, spell checker & internationalisation which are all separate core components, so I don't think so.

Melvin: note, there's a JavaScript reformat of the tree happening on Friday, so you'll need to take account of that in your patches as well.

Flags: needinfo?(standard8)

(In reply to Mark Banner (:standard8) from comment #4)

(In reply to Andrew Overholt [:overholt] from comment #3)

Is there a better component for this bug?

This covers permission manager, spell checker & internationalisation which are all separate core components, so I don't think so.

Thanks. I made it a meta bug (of sorts).

Priority: -- → P3
Summary: Enable more ESLint rules for extensions/ → [meta] Enable more ESLint rules for extensions/

Hey! Can I take this up?

Flags: needinfo?(standard8)

(In reply to Megha from comment #6)

Hey! Can I take this up?

As far as I know Melvin is still working on this. I haven't heard for a little bit though, so passing needinfo across.

Unfortunately I'm just about to not be online for a week, so I don't have anything else to offer you at the moment.

Flags: needinfo?(standard8) → needinfo?(melvingeorge10)

I've not heard any more from Melvin, so opening this up again.

Assignee: melvingeorge10 → nobody
Flags: needinfo?(melvingeorge10)

Hey, Can I work on this?

Flags: needinfo?(standard8)

Hi Megha, yes sure. I've assigned you.

Assignee: nobody → meghajais.mj
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)

Note: I've also just updated the link in comment 0 with a new link to the lines to remove.

Blocks: 1596191

Hi Megha, are you able to address the last few updates?

No longer blocks: 1357557
Flags: needinfo?(meghajais.mj)

I've not heard back from Megha, so I'll take this and get the last few comments address and get this landed.

Assignee: meghajais.mj → standard8
Mentor: standard8
Flags: needinfo?(meghajais.mj)
Attachment #9087986 - Attachment description: Bug 1556380 - Enable more ESLint rules for extensions/. r=standard8 → Bug 1556380 - Enable more ESLint rules for extensions/.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/259a20e6ad45
Enable more ESLint rules for extensions/. r=Ehsan
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Assigning back to Megha as they did most of the work here - Thank you.

Assignee: standard8 → meghajais.mj
You need to log in before you can comment on or make changes to this bug.