[meta] Enable more ESLint rules for extensions/
Categories
(Core :: General, task, P3)
Tracking
()
People
(Reporter: standard8, Assigned: meghaaa)
References
(Blocks 1 open bug)
Details
(Keywords: meta, Whiteboard: [lang=js])
Attachments
(1 file)
In bug 1554121 we enabled ESLint for various directories in extensions/, however we also disabled various rules. Now that bug has landed, we should work to enable the rules that were initially disabled.
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
- Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build (an artifact build is sufficient).
- If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Introduction
- If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
- Start working on this bug.
- Remove the relevant lines from the top-level .eslintrc.js
- Run
./mach eslint extensions - Investigate the issues raised and fix them.
- The ESLint website has more details for most of the rules
- The mozilla/ rules are documented separately
- There's also useful information here about fixing no-undef issues.
- If you have direct questions about this bug, feel free to ask here or on irc.
- Build your change with mach build and test your change with:
./mach xpcshell-test extensions./mach mochitest extensions
- Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code.
- Here's the guide.
- I strongly suggest using moz_phab to push the patch.
- After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
- ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
|
||
Comment 1•3 years ago
|
||
Can i work on this?
|
Reporter | |
Comment 2•3 years ago
|
||
Hi Melvin, yes that's fine, I've assigned it to you. Just one note, when you submit the patch, do you mind trying to not have your name as all-caps? We generally don't do that for submissions.
|
|
Reporter | |
Comment 4•3 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #3)
Is there a better component for this bug?
This covers permission manager, spell checker & internationalisation which are all separate core components, so I don't think so.
Melvin: note, there's a JavaScript reformat of the tree happening on Friday, so you'll need to take account of that in your patches as well.
|
||
Comment 5•3 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #4)
(In reply to Andrew Overholt [:overholt] from comment #3)
Is there a better component for this bug?
This covers permission manager, spell checker & internationalisation which are all separate core components, so I don't think so.
Thanks. I made it a meta bug (of sorts).
|
Assignee | |
Comment 6•3 years ago
|
||
Hey! Can I take this up?
|
|
Assignee | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 7•3 years ago
|
||
(In reply to Megha from comment #6)
Hey! Can I take this up?
As far as I know Melvin is still working on this. I haven't heard for a little bit though, so passing needinfo across.
Unfortunately I'm just about to not be online for a week, so I don't have anything else to offer you at the moment.
|
|
Reporter | |
Comment 8•3 years ago
|
||
I've not heard any more from Melvin, so opening this up again.
|
|
Reporter | |
Comment 10•3 years ago
|
||
Hi Megha, yes sure. I've assigned you.
|
|
Reporter | |
Comment 11•3 years ago
|
||
Note: I've also just updated the link in comment 0 with a new link to the lines to remove.
|
|
Assignee | |
Comment 12•3 years ago
|
||
|
|
Reporter | |
Comment 13•3 years ago
|
||
Hi Megha, are you able to address the last few updates?
|
|
Reporter | |
Comment 14•3 years ago
|
||
I've not heard back from Megha, so I'll take this and get the last few comments address and get this landed.
|
||
Updated•3 years ago
|
|
||
Comment 15•3 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/259a20e6ad45 Enable more ESLint rules for extensions/. r=Ehsan
|
||
Comment 16•3 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 17•3 years ago
|
||
Assigning back to Megha as they did most of the work here - Thank you.
|
||
Updated•3 years ago
|
Description
•