Closed Bug 1556387 Opened 4 months ago Closed 4 months ago

Add missing test for unknown key to Set Timeouts WPT test

Categories

(Testing :: geckodriver, defect)

Version 3
defect
Not set

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(2 files)

As mentioned over in the last few comments on
https://bugzilla.mozilla.org/show_bug.cgi?id=1507782, we’ve adjusted
geckodriver and the WebDriver standard to ignore unknown keys in
the parameters passed to the Set Timeouts command, but we’re
missing a WPT test for that behaviour.

Assignee: nobody → ato
Status: NEW → ASSIGNED

WebDriver is meant to ignore unfamiliar fields in JSON Objects generally,
and whilst we are testing that an empty object, {}, does not mutate
the timeout duration values, we are not testing unknown field keys.

Attachment #9069346 - Attachment description: bug 1507782: webdriver: add test for ignored fields to Set Timeouts; → bug 1556387: webdriver: add test for ignored fields to Set Timeouts;
Attachment #9069347 - Attachment description: bug 1507782: webdriver: compare None types with "is" operator; → bug 1556387: webdriver: compare None types with "is" operator;
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06b0fe7e4fa1
webdriver: compare None types with "is" operator; r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/2cdb92042b95
webdriver: add test for ignored fields to Set Timeouts; r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17142 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.