Closed Bug 1556389 Opened 1 year ago Closed 1 year ago

[about:addons] The report abuse form is not loaded for dictionaries and language packs

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: LexaSV, Assigned: rpl)

References

Details

Attachments

(3 files)

Attached image abuse report frame.gif

[Affected versions]

  • Nightly 69.0a1
  • Beta 68

[Affected platforms]

  • Win 10x64
  • macOS High Sierra 10.13.6

[Steps to Reproduce]

  1. Install a dictionary or a language pack from AMO
  1. Open about:addons -> Dictionaries
  2. Try to report abuse for the installed dictionary

[Actual result]
The report abuse form is not loaded for dictionaries and language packs. The report abuse action will also make addons manager unresponsive until the page is refreshed

[Expected result]
The report abuse form should be loaded for dictionaries and language packs

Blocks: 1540175
Summary: The report abuse form is not loaded for dictionaries and language packs → [about:addons] The report abuse form is not loaded for dictionaries and language packs
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/2edc7c7ea248
Show report action only on currently supported addon types. r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Depends on: 1558540

Is this something which needs to be considered for Beta uplift or can it ride the trains?

Flags: needinfo?(lgreco)

Verified fixed with Nightly 69.0a1 on Win10x64 and macOS 10.14.5

  • dictionaries and language packs no longer have a Report abuse option in about:addons (postfix screencast attached)
Status: RESOLVED → VERIFIED
Attached image no-report-abuse.gif

Comment on attachment 9070948 [details]
Bug 1556389 - Show report action only on currently supported addon types. r?mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: A report action would be visible in the addon card options (part of the HTML about:addons) on addon types that are not currently supported by the abuse reporting feature.
    The abuse report panel will not be visible, but the subframe that contains the report panel will not be hidden and it would prevent the user from being able to click on the elements of the HTML about:addons page (until the user reload, or close and re-open, the about:addons tab).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Same STR used to verify the fix on nightly.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change should not be risky: the actual changes applied are pretty small (one line change in abuse-report-frame.js and a few lines changes on aboutaddons.js), most of the patch is actually new test cases to verify the fix as part of the automated tests.
  • String changes made/needed:
Flags: needinfo?(lgreco)
Attachment #9070948 - Flags: approval-mozilla-beta?
Flags: qe-verify+

(In reply to Luca Greco [:rpl] from comment #7)

  • List of other uplifts needed: None

Can you expand on the relationship with bug 1558540?

Flags: needinfo?(lgreco)

(In reply to Julien Cristau [:jcristau] from comment #8)

(In reply to Luca Greco [:rpl] from comment #7)

  • List of other uplifts needed: None

Can you expand on the relationship with bug 1558540?

Sure, bug 1558540 is going to fix a similar issue but on the "I want to report this extension" checkbox included in the "addon uninstall dialog" (the checkbox is included in that dialog when the abuse reporting feature is enabled from the about:config preference and it opens the abuse report panel right after the addon has been removed).

Ideally I would have preferred to ask one uplift for both, but bug 1558540 is still in review (as it has been filed by QA while verifying this one, and so it has not been landed and it is not verified on nightly yet).

Flags: needinfo?(lgreco)
QA Whiteboard: [qa-triaged]

Comment on attachment 9070948 [details]
Bug 1556389 - Show report action only on currently supported addon types. r?mstriemer

fix for abuse reporting ui, approved for 68.0b10

Attachment #9070948 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed with Beta 68.0b10 on Win10x64 and macOS High Sierra 10.13.6

You need to log in before you can comment on or make changes to this bug.