1556433 - Canvas Flicker in 67.0

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[ptylde]

Attachment: flicker.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Canvas is flickering when viewed in the browser.

Mac (Retina 5K, 27-inch, 2017), Version 10.13.3
Firefox Quantum 67.0

Examples:
https://codepen.io/abeatrize/pen/WBLYGj
https://codepen.io/MSEdgeDev/pen/RpgexG

Actual results:

Canvas flickers

Expected results:

Canvas shouldn't flicker

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1556433 - disable shared buffer provider when using direct texture mapping. r?nical

Comment 3

[Lee Salzman [:lsalzman]]

This appears to be a bug in client texture storage using GL_ARB_sync for fencing textures, and those fences somehow getting signaled too early. Seemingly this issue goes away in later macOS SDKs, which further suggests this is probably an OpenGL bug.

For now, the sanest solution seems to be to just not allow shared buffer provider and client texture storage to coexist until we can find some workaround.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dedfa9da9765
disable shared buffer provider when using direct texture mapping. r=nical

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/dedfa9da9765

Comment 6

[Lee Salzman [:lsalzman]]

Comment on attachment 9070713 [details]
Bug 1556433 - disable shared buffer provider when using direct texture mapping. r?nical

Beta/Release Uplift Approval Request

• User impact if declined: Canvas2D flickering for all macOS users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just disables a Canvas2D performance optimization that is causing problems on macOS.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9070713 [details]
Bug 1556433 - disable shared buffer provider when using direct texture mapping. r?nical

approved for 68.0b10

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/985afd2f2910

Comment 9

[Daniel Bodea [:danibodea]]

I cannot reproduce this issue on MacBook Pro (13-inch, 2017) with OS X 10.13.6 or iMac (21.5-inch, late 2013) with OS X 10.14 on the Firefox release version v67.0.2 or affected Nightly builds. Also attempted o reproduce on a MacBook Pro with a 4k monitor.
Is this bug supposed to reproduce on these systems? Is it specific to the hardware on the 2017 27.5-inch Macintosh?

This being said, I can't validate this issue.
@ptylde: Can you please verify whether this issue reproduces in the latest Firefox Beta and latest Firefox Nightly? It should still reproduce on the release version for now.
You can get them from https://www.mozilla.org/en-US/firefox/channel/desktop/

Thank you for your contribution!