1556516 - custom dimensions lost when editing image parameters

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jonathan Kamens]

1. Compose a message.
2. Insert an image with custom dimensions.
3. Double-click on the image to edit its properties.
4. Note how the Dimensions tab says original rather than custom dimensions.
5. Click OK.

What happens: the custom dimensions are lost when you click OK in step 5.

What should happen: when you edit the image properties, the custom dimensions you should previously should appear in the edit dialog. When you click OK, they should be preserved.

Regression window:

13:52.67 INFO: Running comm-central build built on 2018-10-04 16:23:34.178000, revision f0ac7820
14:10.10 INFO: Launching /tmp/tmpy4Nvs4/thunderbird/thunderbird
14:10.10 INFO: Application command: /tmp/tmpy4Nvs4/thunderbird/thunderbird --allow-downgrade -profile /tmp/tmp22poLL
14:10.11 INFO: application_buildid: 20181004154858
14:10.11 INFO: application_changeset: f0ac78200614874a7157972a822b999a50dd557f
14:10.11 INFO: application_name: Thunderbird
14:10.11 INFO: application_repository: https://hg.mozilla.org/comm-central
14:10.11 INFO: application_version: 64.0a1
Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
14:38.40 INFO: Narrowed inbound regression window from [c2608a68, f386902f] (3 builds) to [f0ac7820, f386902f] (2 builds) (~1 steps left)
14:38.40 INFO: No more inbound revisions, bisection finished.
14:38.40 INFO: Last good revision: f0ac78200614874a7157972a822b999a50dd557f
14:38.40 INFO: First bad revision: f386902fa7325f359d24b88ae5751948b2cae42d
14:38.40 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=f0ac78200614874a7157972a822b999a50dd557f&tochange=f386902fa7325f359d24b88ae5751948b2cae42d

Comment 1

[Jorg K (CEST = GMT+2)]

This will be an M-C regression. Alice, could you work this out for us. There's nothing in the C-C range that would have caused this.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=f0ac78200614874a7157972a822b999a50dd557f&tochange=f386902fa7325f359d24b88ae5751948b2cae42d
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f66e525e6978c2fbc7351501936711876261b546&tochange=863c5a0642a84831b8ff3cac737c8657c70b05f1

Regressed by:
d8313ee5547ec5eb296415d8ec3e03abbc0b21d0 Brian Grinstead — Bug 1496137 - Handle asynchronous XBL construction of <radio> elements beneath <radiogroup>;r=jaws

(I confirmed that reverting the changeset d8313ee5547ec5eb296415d8ec3e03abbc0b21d0 fixed the issue.)

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks so much, Alice. That bug has already caused other chagrin :-( - See bug 1496704.

Time to act? Magnus?

Comment 4

[Jonathan Kamens]

Is there tooling for bisecting M-C with respect to C-C? I'm happy to help with that in the future if it's necessary for one of the bugs I report and somebody can tell me how to do it.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: bug1556516_img_size.patch

The radios need to have a value for things to work.
Might be a bug in radio.js, but having values for them is reasonable.

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, somehow this fell through the cracks. Good we have a patch now.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9075118 [details] [diff] [review]
bug1556516_img_size.patch

Amazing, that works!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/73ce6f5f060a
add value to imgSizerGroup radios to make the radiogroup selection work as intended. r=jorgk

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/517aa246e6307efaa3b4087b970509587b836258