1556548 - Cleanup RenderFrame and nsDisplayRemote a bit

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

1. RenderFrame is poorly named. Its purpose is essentially to create/destroy layer trees for a BrowserParent. The name came from PRenderFrame, back when it was an IPDL protocol. I can't think of a great name, but we should make it a little bitter.
2. RenderFrame is exposed to a good amount of code via BrowserParent. All uses only care about getting a LayersId. We should just make RenderFrame an implementation detail of BrowserParent.
3. nsDisplayRemote lives in RenderFrame.cpp, which made sense when it was only created in the parent process, but now it can work with any nsFrameLoader. We should move it to nsDisplaySubdocument.cpp

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1556548 - Make RenderFrame an internal detail to BrowserParent. r?mattwoodrow,farre

Code outside of BrowserParent should just get the LayersId from a getter
and not worry about RenderFrame.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1556548 - Move nsDisplayRemote to nsSubDocumentFrame.cpp. r?mattwoodrow

nsDisplayRemote no longer has any direct ties to RenderFrame and should
be moved to nsSubDocumentFrame.cpp where it's actually used/created.

Depends on D33562

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1556548 - Rename RenderFrame to RemoteLayerTreeOwner. r?mattwoodrow

RenderFrame is a very poor name for what this class does. LayerTreeOwner
isn't great (it's not the only thing that owns layer trees), but it's
hopefully clearer.

Depends on D33563

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07506e0069c5
Make RenderFrame an internal detail to BrowserParent. r=mattwoodrow,farre
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbb75fada79b
Move nsDisplayRemote to nsSubDocumentFrame.cpp. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/26f5de904414
Rename RenderFrame to RemoteLayerTreeOwner. r=mattwoodrow

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/07506e0069c5
https://hg.mozilla.org/mozilla-central/rev/dbb75fada79b
https://hg.mozilla.org/mozilla-central/rev/26f5de904414