1556602 - --enable-warnings-as-errors fails due to -D bare-trait-objects with Rust 1.37

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Jan Beich]

$ rustc -vV
rustc 1.37.0-nightly
binary: rustc
commit-hash: 7840a0b753a0
commit-date: 2019-05-31
host: x86_64-unknown-freebsd
release: 1.37.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: trait objects without an explicit dyn are deprecated
--> servo/components/selectors/context.rs:137:48
|
137 | pub pseudo_element_matching_fn: Option<&'a Fn(&Impl::PseudoElement) -> bool>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use dyn: dyn Fn(&Impl::PseudoElement) -> bool
|
= note: -D bare-trait-objects implied by -D warnings
error: aborting due to previous error

Comment 1

[Jan Beich]

Probably regressed by https://github.com/rust-lang/rust/pull/61203 which was merged into Nightly on 2019-05-29.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Sorry, this somehow fell off the radar.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1556602 - Fix various warnings with rust 1.37 nightly. r=froydnj,#style

In particular:

• trait objects without an explicit dyn are deprecated
• ... range patterns are deprecated

I think these shouldn't really warn by default and should be clippy / opt-in
lints, but anyway, doesn't hurt.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/046dd0da3b8e
Fix various warnings with rust 1.37 nightly. r=froydnj

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/046dd0da3b8e