--enable-warnings-as-errors fails due to -D bare-trait-objects with Rust 1.37
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jbeich, Assigned: emilio)
References
Details
Attachments
(1 file)
$ rustc -vV
rustc 1.37.0-nightly
binary: rustc
commit-hash: 7840a0b753a0
commit-date: 2019-05-31
host: x86_64-unknown-freebsd
release: 1.37.0-nightly
LLVM version: 8.0
$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: trait objects without an explicit dyn are deprecated
--> servo/components/selectors/context.rs:137:48
|
137 | pub pseudo_element_matching_fn: Option<&'a Fn(&Impl::PseudoElement) -> bool>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use dyn: dyn Fn(&Impl::PseudoElement) -> bool
|
= note: -D bare-trait-objects implied by -D warnings
error: aborting due to previous error
Probably regressed by https://github.com/rust-lang/rust/pull/61203 which was merged into Nightly on 2019-05-29.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 3•5 years ago
|
||
In particular:
- trait objects without an explicit
dynare deprecated ...range patterns are deprecated
I think these shouldn't really warn by default and should be clippy / opt-in
lints, but anyway, doesn't hurt.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/046dd0da3b8e Fix various warnings with rust 1.37 nightly. r=froydnj
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•