--enable-warnings-as-errors fails due to -D bare-trait-objects with Rust 1.37

RESOLVED FIXED in Firefox 69

Status

()

defect
P3
normal
RESOLVED FIXED
2 months ago
Last month

People

(Reporter: jbeich, Assigned: emilio)

Tracking

Trunk
mozilla69
Points:
---

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

$ rustc -vV
rustc 1.37.0-nightly
binary: rustc
commit-hash: 7840a0b753a0
commit-date: 2019-05-31
host: x86_64-unknown-freebsd
release: 1.37.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: trait objects without an explicit dyn are deprecated
--> servo/components/selectors/context.rs:137:48
|
137 | pub pseudo_element_matching_fn: Option<&'a Fn(&Impl::PseudoElement) -> bool>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use dyn: dyn Fn(&Impl::PseudoElement) -> bool
|
= note: -D bare-trait-objects implied by -D warnings
error: aborting due to previous error

Probably regressed by https://github.com/rust-lang/rust/pull/61203 which was merged into Nightly on 2019-05-29.

See Also: → 1556510
Priority: -- → P3

Sorry, this somehow fell off the radar.

Assignee: nobody → emilio

In particular:

  • trait objects without an explicit dyn are deprecated
  • ... range patterns are deprecated

I think these shouldn't really warn by default and should be clippy / opt-in
lints, but anyway, doesn't hurt.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/046dd0da3b8e
Fix various warnings with rust 1.37 nightly. r=froydnj
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.