1556637 - Replace all mozDumpDebugInfo calls

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Tarek Ziadé (:tarek)]

The API was removed in bug 1542674

but they are remaining calls, see https://searchfox.org/mozilla-central/search?q=DumpDebugInfo&case=false&regexp=false&path=

Comment 1

[Andreas Pehrson [:pehrsons]]

On mochitest failures we have significantly less debug information now. Any chance you could prioritize this?

Comment 2

[Tarek Ziadé (:tarek)]

yeah sure, will try to fix that this week

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: Bug 1556637 - Replace all mozDumpDebugInfo calls r?jya,jib

Replaces mozDumpDebugInfo with mozRequestDebugInfo

Comment 4

[Tarek Ziadé (:tarek)]

I am going to launch a try that runs all media tests but I guess we need to make sure things happens correctly when we get time outs. Do you have a way to verify this before we land? thanks!

Comment 5

[Andreas Pehrson [:pehrsons]]

Adding artificial timeouts to a test like dom/media/test/test_playback.html and running it locally should work. Making sure it works for the last test case with --keep-open=false is probably the most interesting corner case.

I'm just wrapping up my work before a 2-week PTO, so I won't have time to play with this today unfortunately.

Comment 6

[Tarek Ziadé (:tarek)]

No problem Andreas, I will address the patch comments and see to simulate timeouts

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tarek, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Tarek Ziadé (:tarek)]

Try build https://treeherder.mozilla.org/#/jobs?repo=try&revision=362b1dd6139236fe99000363b31268edc9fafe24

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05b192f3ba82
Replace all mozDumpDebugInfo calls r=jya,jib

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/05b192f3ba82