Closed Bug 1556650 Opened 6 years ago Closed 6 years ago

Refactor `<metricType>.shouldRecord` to avoid code duplication

Categories

(Data Platform and Tools :: Glean: SDK, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: Dexter, Unassigned)

Details

(Whiteboard: [telemetry:glean-rs:backlog])

The shouldRecord pattern is used in every single metric type on the Kotlin side. Maybe we can avoid some code duplication if we find a smart way to refactor this.

Priority: -- → P3
Whiteboard: [telemetry:glean-rs:m?]

Also side note: They are currently public, and should probably be private, or at least internal.

Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:backlog]

We removed shouldRecord in the Kotlin part.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.