1556680 - [Translate.Next] Potential issues with translation memory

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Francesco Lodolo [:flod]]

Yesterday 4 strings for android-l10n were moved to a different file. I translated them a few days earlier for Italian (in Translate.Next), but didn't get any machinery matches.
https://pontoon.mozilla.org/it/android-l10n/mozilla-mobile/android-components/components/feature/app-links/src/main/res/values/strings.xml/?string=199702

For comparison, French and German got them.
https://pontoon.mozilla.org/fr/android-l10n/mozilla-mobile/android-components/components/feature/app-links/src/main/res/values/strings.xml/?string=199702

Can it be that Translate.Next is not correctly storing translations in translation memory? How is that managed?

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Testing locally, when I add a string through Translate.Next, I can successfully see it in Machinery. However, I can only see it from other strings, because our algorithm will not pull translations that come from the current entity.

In this case, I wonder what's happening. Could it be flod that you translated after the move? If not, I can't think of a good explanation for this.

Comment 2

[Francesco Lodolo [:flod]]

No, it was translated before the move. Also, why it's still showing up for de and fr?

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Sorry, I really have no idea what's going on. Deferring to Matjaz.

Comment 4

[Jarek Śmiejczak [:jotes]]

:adrian

I had a chance to read through the code of Translate.Next. It looks like the method responsible for approval of the translation approve() removes the TM entry of translation.
On my local instance, Translate.next removes entries from TM after I trigger an approve event on the translation.
Sorry if it's a false alarm and is not related to the issue.

Comment 5

[Matjaz Horvat [:mathjazz]]

Confirming that jotes is right: when suggestion gets approved, we delete its TM entry (which doesn't exist, so we don't do anything actually). Instead, we should create a TM entry.

The dedicated approve method is only used by Translate.Next:
https://github.com/mozilla/pontoon/commit/17dba2c3f2c46a333067be70885a92f57b3bd254#diff-c18ce63ddb8aca155c0553a0c1b174e3R2964

Working on a patch.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1313

Comment 7

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/58d463041240d69a85e565542e6b6c385dcb8ebf