Open
Bug 1556683
Opened 5 years ago
Updated 2 years ago
GetPaintedLayerScaleForFrame returns wrong values on non-E10S
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
NEW
People
(Reporter: hiro, Unassigned)
References
()
Details
FrameLayerBuilder::GetPaintedLayerScaleForFrame tries to get the root pres context, on Fennec it's the pres context for browser.xul so that the returned value is not useful at all. (there might be cases it's useful though, I've not audited all call sites)
|
||
Comment 1•5 years ago
|
||
It sounds like perhaps we should be using aFrame->PresShell()->GetCumulativeResolution() here.
|
Reporter | |
Comment 2•5 years ago
|
||
Oh right, looks like it. I did just push a try run to see what happens there. (I'd expect some of wpt fail)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d814c5e37d64012269906f29e557098c3f86de15
|
|
Reporter | |
Comment 3•5 years ago
|
||
There are more failures than I expected. :/ For example a mochitest failed, it seems the mochitest has been disabled on GeckoView.
|
||
Updated•2 years ago
|
Severity: normal → S3
|
||
Updated•2 years ago
|
Summary: FrameLayerBuilder::GetPaintedLayerScaleForFrame returns wrong values on non-E10S → GetPaintedLayerScaleForFrame returns wrong values on non-E10S
You need to log in
before you can comment on or make changes to this bug.
Description
•