Closed Bug 1556717 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 17164 - Wrap event handlers in Client Hints tests in `t.step_func`

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17164 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17164
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:

Wrap event handlers in Client Hints tests in t.step_func

Without this, any failed assert will cause a harness error instead of
failing the test.

Note that some problematic use like
win.addEventListener('load', acceptChLifetimeLoaded, false) remains,
but fixing these would require introducing new tests.

Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e8562e577b7 [wpt PR 17164] - Wrap event handlers in Client Hints tests in `t.step_func`, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9e8562e577b7

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.