1556730 - QM: Add IsShuttingDown checks to temporary storage initialization

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P1)

Description

[Jan Varga [:janv]]

We found out that temporary storage initialization can block shutdown for long time, see bug 1541776 comment 17. This can be mitigated by adding IsShuttingDown checks to every loop that traverses directories/files. We are adding these checks to quota manager only for now. We can add them to quota clients later if we find a reason for that.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1556730 - QM: Add IsShuttingDown checks to temporary storage initialization; r=asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7b4ce10f4ee
QM: Add IsShuttingDown checks to temporary storage initialization; r=asuth

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b7b4ce10f4ee

Comment 4

[steve]

Are there plans to uplift this to firefox68? seeing https://bugzilla.mozilla.org/show_bug.cgi?id=1541928 with very high frequency.

Comment 5

[Jan Varga [:janv]]

Yeah, but we need to test it on Nightly first.

Comment 6

[Jan Varga [:janv]]

Comment on attachment 9069646 [details]
Bug 1556730 - QM: Add IsShuttingDown checks to temporary storage initialization; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: Users would still experience frequent IndexedDB shutdown hangs.
  IndexedDB shutdown hangs are tracked in bug 1541776.
  The patch may also help to reduce shutdown hangs tracked in bug 1541928.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is simple, it just aborts temporary storage initialization if the app is shutting down.
• String changes made/needed: None

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9069646 [details]
Bug 1556730 - QM: Add IsShuttingDown checks to temporary storage initialization; r=asuth

bail out of quota manager instead of holding up shutdown; let's try this in 68.0b8.

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f60cd8f26e67