1556757 - The "Visit the theme's website" link is not working during report abuse flow

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Victor Carciu]

Attachment: Video

Steps to reproduce:

1. Install a theme with a support site (ie. https://addons-dev.allizom.org/en-US/firefox/addon/victorrrrr/)
   2.From about:addons , Themes section, try to report the theme using the "Doesn't work or breaks browser display"
   3.Click the "Visit the theme's website" link from next step

Expected results:
Theme's support site should be opened

Actual results:
Nothing happens

Please see attached video for this issue.

NOTES:
Working for Extensions

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1556757 - Abuse Report panel should not show the 'broken reason' suggestion when addon support url is missing. r?mstriemer!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc6b4b3480aa
Abuse Report panel should not show the 'broken reason' suggestion when addon support url is missing. r=mstriemer

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/fc6b4b3480aa

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta & ESR68 approval when you get a chance.

Comment 6

[Victor Carciu]

Verified as fixed in latest FF70 .
Please see postfix screenshot attached.

Comment 7

[Victor Carciu]

Attachment: Postfix Screenshot

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9073587 [details]
Bug 1556757 - Abuse Report panel should not show the 'broken reason' suggestion when addon support url is missing. r?mstriemer!

Beta/Release Uplift Approval Request

• User impact if declined: The abuse report panel may be showing a link to a addon support url even if not available for the addon being reported, clicking on the link will not open any webpage.

With the fix applied, the suggestion with the support url will only be visible if an addon support url is available.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same STR used to verify it on Nightly
• List of other uplifts needed: Bug 1556403
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small change (also restricted to the abuse report panel), covered by automated tests.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9073587 [details]
Bug 1556757 - Abuse Report panel should not show the 'broken reason' suggestion when addon support url is missing. r?mstriemer!

Don't show the link to the theme's website when the metadata is missing. Approved for 69.0b6.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a706b0b75316

Comment 11

[Victor Carciu]

Verified as fixed in FF 69.0b6.