1556786 - Header boxes are misaligned in day view and week view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: header-boxes.png

Thunderbird 69.0a1 (20190604091847) with Lightning 7.1a1 on Windows 10.

In day view and week view the header boxes are misaligned. See screenshot.

Comment 1

[Stefan Sitter [:ssitter]]

Works fine using Thunderbird 68.0a1 (20190520104136) with Lightning 7.0a1, i.e. only Lightning 7.1 seems affected.

Comment 2

[Stefan Sitter [:ssitter]]

Broken in Thunderbird 68.0b1 (20190606200316) with Lightning 7.0.

Comment 4

[Jorg K (CEST = GMT+2)]

Regressed by bug 1535725, which hunk? The last one?
https://hg.mozilla.org/comm-central/rev/12e96412b2c8
That could be backed out of beta if necessary.

So what was wrong about that?

Comment 5

[Geoff Lankow (:darktrojan)]

All of https://hg.mozilla.org/releases/comm-beta/rev/a3f862000ed8fb0d4d1ce976b5a3c9f665cfbcc0 can be backed out. It'll still be broken in Daily.

Comment 6

[Geoff Lankow (:darktrojan)]

Needinfo? Jorg to back out.

Comment 7

[Jorg K (CEST = GMT+2)]

I can back it out, bug can't it be fixed properly?

Comment 8

[Geoff Lankow (:darktrojan)]

I'm sure it can, but there's no need for it to be broken in beta. Are we trying to release a product here or what?

Comment 9

[Jorg K (CEST = GMT+2)]

Yes, but I prefer to avoid diverging branches as much as possible. We're far from releasing a product without regressions, but if this is the last regression, I will do the backout.

Comment 10

[Magnus Melin [:mkmelin]]

Before we back out, let me take a loot. The patch is small so this should be possible to just fix.

Comment 11

[Magnus Melin [:mkmelin]]

Take a look.

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: bug1556786_cal_header_off.patch

Not sure exactly what's going on here. May be several issues.
In 60, the whole view had a scrollbar but that didn't go up beside the actual header.

On trunk, the header goes all the way to the left (no empty space for the scrollbar).

Then, scrollbar de-xbl (I think) changed things, so the scrollbox scrollbar is not the firstchild.
The attached patch kind of fixes things, but since it's commenting out setting the overflows, it also mess some things up.

Comment 13

[Magnus Melin [:mkmelin]]

(In reply to Magnus Melin [:mkmelin] from comment #12)

On trunk, the header goes all the way to the left

To the right, I meant.

Comment 14

[Paul Morris [:pmorris]]

Attachment: calendar-view-header-alignment-0.patch

This patch fixes the alignment problem, and I was not able to reproduce bug 1561093 with this patch applied.

For some reason the <scrollbar> is not accessible from the <scrollbox>. this.scrollbox.querySelector("scrollbar") always returns null. It's odd because when inspecting the <scrollbox> in the dev tools I can see the <scrollbar> as its last child. But then if I log the <scrollbox> to the console its innerHTML property does not include the <scrollbar>.

(Perhaps the <scrollbar> is now shadow DOM? But I thought the dev tools indicated shadow DOM and I didn't see anything like that.)

So, since we can't access the size of the scrollbar directly, this patch just calculates it.

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 9074281 [details] [diff] [review]
calendar-view-header-alignment-0.patch

Review of attachment 9074281 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! The days before Thursday may be 1-2px off when i look closely. Not sure why that would be.

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: header-w-patch.png

Comment 17

[Paul Morris [:pmorris]]

Attachment: calendar-view-header-alignment-1.patch

Good catch on that one pixel offset. This version of the patch fixes that with a couple of CSS changes.

Comment 18

[Jorg K (CEST = GMT+2)]

Looks OK to me now, the change to the reviewed version is only these two CSS changes:
https://bugzilla.mozilla.org/attachment.cgi?oldid=9074281&action=interdiff&newid=9074311&headers=1

I have no other patch to land, so this is going in now ;-)

Clearing NI since we can uplift this instead of doing the beta backout.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9f2d18f74b15
Fix header box alignment in day and week views. r=mkmelin

Comment 20

[Richard Marti (:Paenglab)]

Comment on attachment 9074311 [details] [diff] [review]
calendar-view-header-alignment-1.patch

Thanks.

Comment 21

[Jorg K (CEST = GMT+2)]

TB 68 beta 3 / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/a59171d7f4b7e57baca21c5c718b24dc6a99d3ff

Comment 22

[[e-mail]]

Is the above a working beta? I am running 68 b2 and TB shows that's the latest one.

Roland

Comment 23

[Jorg K (CEST = GMT+2)]

Will be fixed in beta 3.

Comment 24

[WaltS48 [:walts48]]

(In reply to Jorg K (GMT+2) from comment #23)

Will be fixed in beta 3.

This is fixed in beta 3 with a new profile, but doesn't get fixed on an update from beta 2 to beta 3.

At least not in my release candidate testing on Windows 10 and Ubuntu 18.04.2 LTS.

Anything else I needed to do?

Comment 25

[Jorg K (CEST = GMT+2)]

No idea, Calendar updates are a constant pain. Most likely the add-on didn't update in the existing profile. Try removing the XPI from the profile, reset the magic distro pref and enable/disable the add-on until it finally works :-( - Took me a while.

Comment 27

[Jorg K (CEST = GMT+2)]

See bug 1562352 for the non-update :-(

Comment 28

[Wayne Mery (:wsmwk)]

(In reply to WaltS48 [:walts48] from comment #24)

(In reply to Jorg K (GMT+2) from comment #23)

Will be fixed in beta 3.

This is fixed in beta 3 with a new profile, but doesn't get fixed on an update from beta 2 to beta 3.

At least not in my release candidate testing on Windows 10 and Ubuntu 18.04.2 LTS.

I see the same thing with beta 4 on win10

Comment 29

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+2) from comment #27)

See bug 1562352 for the non-update :-(
Ah, yes.

Comment 30

[[e-mail]]

I don't quite follow the thread. I am now on beta 3 yet the calendar's columns are still not aligned with the header. Do I need to install a full version of beta 3 to get this corrected?

Roland

Comment 31

[Jorg K (CEST = GMT+2)]

There are issues updating. Use TB 68 beta 4 and follow the release notes:
https://www-stage.thunderbird.net/en-US/thunderbird/68.0beta/releasenotes/ - Section "Known Issues".

Comment 32

[[e-mail]]

How do I get to: "Set preference extensions.lastAppVersion to a value of 67.0 to force a refresh." I do not see where the "preference" is.

Roland

Comment 33

[Sorin Sfirlogea]

(In reply to [e-mail] from comment #32)

How do I get to: "Set preference extensions.lastAppVersion to a value of 67.0 to force a refresh." I do not see where the "preference" is.

Roland

Go to Edit > Preferences > Advanced > General tab
Then click on Config Editor button. Search for the value and change it.

Comment 34

[[e-mail]]

OK, did that but now I lost my calendar tab! I can't seem to get it back. How do I get the calendar tab back?

Comment 35

[Sorin Sfirlogea]

(In reply to [e-mail] from comment #34)

OK, did that but now I lost my calendar tab! I can't seem to get it back. How do I get the calendar tab back?

Be creative :-)
Disable and re-enable the Lightning extension. It will come back.

Comment 36

[[e-mail]]

The calendar files are still there and I tried all the menu options and don't see how to get the calendar tab back. I can't even look it it now.

Comment 37

[[e-mail]]

OK, did it and now it works, thanks!

Comment 38

[[e-mail]]

Sorin, I want to thank you for your help. In the process, I've learned quite a bit and am very appreciative! Exercises like this are very educational.

Thanks again!

Comment 39

[Sorin Sfirlogea]

(In reply to [e-mail] from comment #38)

Sorin, I want to thank you for your help. In the process, I've learned quite a bit and am very appreciative! Exercises like this are very educational.

Thanks again!

Happy to help. We all learn here.