1556804 - Change callers of addTestEngines to use objects for the details rather than an array of parameters

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mark Banner (:standard8)]

In bug 1553237 we want to simplify nsISearchService.addEngineWithDetails to only have two arguments - the name and an options object.

To work towards this, we need to change the addTestEngines callers in the two head_search.js files. See this link for references.

We'll need to change the calls to addEngineWithDetails to pass item.details rather than the de-structured ...item.details.

Also, we'll need to change the callers of addTestEngines to pass in objects rather than details arrays, e.g.

{ name: "BigIcon",
  details: {
    iconUrl, "", "Big icon", "GET",
    "http://test_big_icon/search?q={searchTerms}"] },

would change to:

{ name: "BigIcon",
  details: {
    iconURL: iconUrl, 
    description: "Big icon",
    method: "GET",
    template: "http://test_big_icon/search?q={searchTerms}"
  }
},

Comment 1

[Karan Sapolia]

Hi Mark,
I would like to work on this one. Could you please assign me for this?

Comment 2

[Mark Banner (:standard8)]

Yes sure. Note that the steps in bug 1553236 comment 1 mostly apply here as well. You've done step 1, for step 3 see what I put in comment 0 of this bug.

Comment 3

[Karan Sapolia]

Attachment: Bug 1556804 - Change callers of addTestEngines to use objects for details rather than an array. r=standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51deb82b686d
Change callers of addTestEngines to use objects for details rather than an array. r=Standard8

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/51deb82b686d