Closed Bug 1556804 Opened 6 months ago Closed 6 months ago

Change callers of addTestEngines to use objects for the details rather than an array of parameters

Categories

(Firefox :: Search, task)

task
Not set

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: standard8, Assigned: sapoliakaran)

References

Details

Attachments

(1 file)

In bug 1553237 we want to simplify nsISearchService.addEngineWithDetails to only have two arguments - the name and an options object.

To work towards this, we need to change the addTestEngines callers in the two head_search.js files. See this link for references.

We'll need to change the calls to addEngineWithDetails to pass item.details rather than the de-structured ...item.details.

Also, we'll need to change the callers of addTestEngines to pass in objects rather than details arrays, e.g.

{ name: "BigIcon",
  details: {
    iconUrl, "", "Big icon", "GET",
    "http://test_big_icon/search?q={searchTerms}"] },

would change to:

{ name: "BigIcon",
  details: {
    iconURL: iconUrl, 
    description: "Big icon",
    method: "GET",
    template: "http://test_big_icon/search?q={searchTerms}"
  }
},

Hi Mark,
I would like to work on this one. Could you please assign me for this?

Yes sure. Note that the steps in bug 1553236 comment 1 mostly apply here as well. You've done step 1, for step 3 see what I put in comment 0 of this bug.

Assignee: nobody → sapoliakaran
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51deb82b686d
Change callers of addTestEngines to use objects for details rather than an array. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.