Closed Bug 1556840 Opened 2 years ago Closed 2 years ago

Enable more ESLint rules for image/

Categories

(Core :: ImageLib, task, P3)

Product:
Core
Component:
ImageLib
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: standard8, Assigned: kanurag94, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js] [gfx-noted])

Attachments

(1 file)

Bug 1556840 - Enable more ESLint rules for image/. r=standard8
47 bytes, text/x-phabricator-request
Details | Review

In bug 1554142 we enabled ESLint for image/, however we also disabled various rules. Now that bug has landed, we should work to enable the rules that were initially disabled.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build (an artifact build is sufficient).
  3. Start working on this bug.
  4. Build your change with mach build and test your change with:
    • ./mach xpcshell-test image
    • ./mach mochitest image
  5. Submit the patch for review. Mark me as a reviewer (r?standard8) so I'll get an email to come look at your code. I'll be doing an initial review of the patch, then passing it to image/ peers for final review.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Depends on: 1554142
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [lang=js] → [lang=js] [gfx-noted]

Hey, can I take this up as my first contribution?

Thanks! :)

Hi Rishabh, thank you for the offer, I've assigned it to you.

Assignee: nobody → rishabh.budhiraja
Status: NEW → ASSIGNED

(In reply to Mark Banner (:standard8) from comment #2)

Hi Rishabh, thank you for the offer, I've assigned it to you.

My apologies for the delay. I got busy with another task. I will get right back to this and ask you if I get stuck anywhere. Thanks!

Hey, can I take this up?

(In reply to Megha from comment #4)

Hey, can I take this up?

Hey Megha! I'm working on this! :)

Anurag, generally it is polite to ask if you take over a bug someone's assigned to, sometimes they just get delayed. However in this case I haven't heard from Rishabh for a while, and I pinged them last week, so handing this over.

Assignee: rishabh.budhiraja → kanurag94

Hey Mark!

I'm sorry for not keeping up with this! I tried multiple times to get firefox build up and running, but always got an error in the mach build command stage.

I tried to reach out on Mozilla IRC, but couldn't solve the issue there as well.

I apologize for not getting back here on time!

Anurag, you can take this up :)

Mark, I apologize for taking over like this. Thanks !

Rishabh, I'm sorry, I didn't ask first. Thanks for letting me take over!

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3be18873536a
Enable more ESLint rules for image/. r=Standard8,aosmond

Anurag, thank you for your work on this, this is now on our integration branch, and should be merged to the master mozilla-central within a day if there's no issues found in automation.

https://hg.mozilla.org/mozilla-central/rev/3be18873536a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.