1556847 - Fix some control logic bugs

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect, P3)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

This patch fixes some problems that showed up while testing the new control logic on longer lived tabs.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1556847 - Fix various record/replay bugs, r=loganfsmyth.

Depends on D34953

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:bhackett, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf0b6a8dd13
Fix various record/replay bugs, r=loganfsmyth.

Comment 4

[Raul Gurzau (:RaulG)]

Backed out 3 changesets (bug 1556847, bug 1556858, bug 1405402) for eslint failures at /actors/replay/debugger.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/756e8d09a98ff8869a8065337e1f2d2f9816e126

Pushes with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=1bf0b6a8dd1309ee22bd5b3593ca150172b644a9&selectedJob=257596995

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=099de68d4716a2c7ba843c5cfcf053bd25fcf91c&selectedJob=257597102

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=03df8624c36c9434ab73dcd8c118563310e81c85&selectedJob=257597123

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257596995&repo=mozilla-inbound&lineNumber=290

Log snippet:
[task 2019-07-21T18:16:52.027Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-07-21T18:16:52.027Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-07-21T18:16:52.027Z]
[task 2019-07-21T18:16:52.027Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:548:28 | Insert ??????? (prettier/prettier)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:549:7 | Replace type:?"getSource", with ??type:?"getSource",???????? (prettier/prettier)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:550:1 | Replace ????}) with ??????})????? (prettier/prettier)
[taskcluster 2019-07-21 18:33:27.578Z] === Task Finished ===
[taskcluster 2019-07-21 18:33:28.586Z] Unsuccessful task run with exit code: 1 completed in 1368.153 seconds

Comment 5

[Brian Hackett [Laid off!]]

Hmm, the try run linked below includes these changesets and had a green ESLint run. What did I do wrong?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03cedada71f29d27086c86d341f29883a0b20997

Comment 6

[Brian Hackett [Laid off!]]

Hmm, looking closer the try run didn't include any new changes at all, whoops.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f2235fa1c45
Fix various record/replay bugs, r=loganfsmyth.

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2f2235fa1c45