Closed Bug 1556847 Opened 2 years ago Closed 2 years ago

Fix some control logic bugs

Categories

(Core Graveyard :: Web Replay, defect, P3)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch patchSplinter Review

This patch fixes some problems that showed up while testing the new control logic on longer lived tabs.

The priority flag is not set for this bug.
:bhackett, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bhackett1024)
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf0b6a8dd13
Fix various record/replay bugs, r=loganfsmyth.

Backed out 3 changesets (bug 1556847, bug 1556858, bug 1405402) for eslint failures at /actors/replay/debugger.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/756e8d09a98ff8869a8065337e1f2d2f9816e126

Pushes with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=1bf0b6a8dd1309ee22bd5b3593ca150172b644a9&selectedJob=257596995

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=099de68d4716a2c7ba843c5cfcf053bd25fcf91c&selectedJob=257597102

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=03df8624c36c9434ab73dcd8c118563310e81c85&selectedJob=257597123

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257596995&repo=mozilla-inbound&lineNumber=290

Log snippet:
[task 2019-07-21T18:16:52.027Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-07-21T18:16:52.027Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-07-21T18:16:52.027Z]
[task 2019-07-21T18:16:52.027Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:548:28 | Insert ??????? (prettier/prettier)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:549:7 | Replace type:?"getSource", with ??type:?"getSource",???????? (prettier/prettier)
[task 2019-07-21T18:33:27.238Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/replay/debugger.js:550:1 | Replace ????}) with ??????})????? (prettier/prettier)
[taskcluster 2019-07-21 18:33:27.578Z] === Task Finished ===
[taskcluster 2019-07-21 18:33:28.586Z] Unsuccessful task run with exit code: 1 completed in 1368.153 seconds

Hmm, the try run linked below includes these changesets and had a green ESLint run. What did I do wrong?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03cedada71f29d27086c86d341f29883a0b20997

Flags: needinfo?(bhackett1024)

Hmm, looking closer the try run didn't include any new changes at all, whoops.

Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f2235fa1c45
Fix various record/replay bugs, r=loganfsmyth.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → bhackett1024
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.