Closed Bug 1556860 Opened 7 years ago Closed 6 years ago

[wpt-sync] Sync PR 17176 - Removing initial Element Timing implicit registration heuristic.

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17176 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17176
Details from upstream follow.

Tom McKee <tommckee@chromium.org> wrote:

Removing initial Element Timing implicit registration heuristic.

The Element Timing specification originally included a provision for reporting
timings of elements that were automatically detected as 'important'. This would
allow useful inforation from the Element Timing API to be reported through the
Performance Timeline even if site authors neglected to mark their important
elements with the 'elementtiming' attribute.

The automatic detection of 'important' elements is, necessarily, a heuristic
and, until consensus for the correct heuristic had been reached, we were
treating any image that occupied greater than %15 of the viewport as
'automatically important'. As the Element Timing specification is still being
refined, the exact threshold and heuristic is still being investigated. Until
agreement on an appropriate heuristic is reached, implicit registration will be
disabled.

This CL removes our %15 threshold and disables implicit registration. There was
also WPT coverage to test that all browsers would respect the %15 threshold so
that test is being removed too.

Change-Id: I14847533402f5a68bb3de63a8f9acbd004c5a8e4
Reviewed-on: https://chromium-review.googlesource.com/1643379
WPT-Export-Revision: 84d93ae87ef6d5664cc4f9a2c61aad6e2e1a1075

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 17176 applied with additional changes from upstream: 163424c5e76ef73bd0ddecf9b8aa7aabc555ccb1
Whiteboard: [wptsync downstream error] → [wptsync downstream]
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/0efad2b60787 [wpt PR 17176] - Removing initial Element Timing implicit registration heuristic., a=testonly

https://hg.mozilla.org/mozilla-central/rev/0efad2b60787

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.