Closed Bug 1556864 Opened 6 years ago Closed 6 years ago

No way to unapprove a changeset I accidentally approved, but without requesting changes

Categories

(Conduit :: Phabricator, defect)

Product:
Conduit
Component:
Phabricator
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: bzbarsky, Unassigned)

Details

STEPS TO REPRODUCE:

  1. Start reviewing a changeset.
  2. Write some comments asking the patch author questions so you can understand whether the changes are correct.
  3. Accidentally select "Accept Revision" in the "Add Action" menu.

EXPECTED RESULTS: I can now go back to a state where I can submit my comments, but neither accept the revision not request changes, because I'm not sure which of those is right here until I get my answers. That is, I want to undo the so-far-unsubmitted "Add Action" bit.

ACTUAL RESULTS: There is no way to do this. I can change which action I'm adding, but I can't not add an action at all at this point.

Kwan pointed out the faint "X" on the right-hand side of the bar above the comment area that lets me get rid of the action. Sorry for the noise....

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.