1556936 - Content tab address bar needs to not look like it's editable

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Geoff Lankow (:darktrojan)]

The address bar looks too much like a browser address bar. That's frustrating because it isn't one. I think we should lose the border and background colours on it.

Other problems:

• There's no icon, just a blank space, for a plain HTTP page.
• The address can't be copied to the clipboard.
• The displayed address doesn't change if the content tab navigates to a different URL.

We should probably also make any changes to the pop-up windows we use for things like OAuth authorisation.

Comment 1

[Richard Marti (:Paenglab)]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

Other problems:

• There's no icon, just a blank space, for a plain HTTP page.
• The address can't be copied to the clipboard.
• The displayed address doesn't change if the content tab navigates to a different URL.

All this are regression by bug 1535265.

Comment 2

[Geoff Lankow (:darktrojan)]

All this are regression by bug 1535265.

The last one appears to be, the other two were also present before. Okay, that's not true either, you could copy it, but it didn't work when I just tried it.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1556936-contentTabUrlbar.patch

First I moved some code from platform searchBox.css to a shared one.

With the value of the label the text isn't selectable -> changed.

I decided to let it still look like a textbox but with a lighter border to look more like disabled. What do you think?

When the window is inactive, the selection isn't visible like on real textboxes. This needed a bit a hack as only setting the rule for ::selection made the selection invisible also with active window.

Comment 4

[Geoff Lankow (:darktrojan)]

I don't understand why you think it should look like a textbox when it isn't one.

The selection bit doesn't seem to work on my Linux box. Hard to know why but it seems like :-moz-window-inactive isn't doing what it's supposed to do.

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

I don't understand why you think it should look like a textbox when it isn't one.

The selection bit doesn't seem to work on my Linux box. Hard to know why but it seems like :-moz-window-inactive isn't doing what it's supposed to do.

I need to check this on Linux.

Comment 6

[Richard Marti (:Paenglab)]

Alessandro, what do you think, should this URL be presented plain on the toolbar or in a textbox which looks like disabled to imitate a URL bar?

To get such a tab, open the about dialog and click on the Mozilla link.

Comment 7

[Alessandro Castellani [:aleca]]

Hey, thanks for pulling me into this.

I think it definitely shouldn't look like a URL bar, not even a disabled one, as it doesn't carry any of the functionalities of that specific object.
I'd suggest to drop any sort of textbox decoration and leave the URL as simple selectable text.
I think we should also remove the magnifying glass icon, as that could be misleading to the user. No icons would be fine, I think, but if we want we could replace it with the hyperlink icon.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1556936-contentTabUrlbar.patch

Okay, removed the textbox appearance.

Geoff, for me the inactive selection rule works on Linux. It doesn't work, when I only click on the desktop but activate another program.

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9070343 [details] [diff] [review]
1556936-contentTabUrlbar.patch

Review of attachment 9070343 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me.
ui-r+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e24c0dd78699
Fix contentTabUrlbar regressions from bug 1535265, remove the textbox appearance and use a shared searchBox.css. r=darktrojan ui-r=aleca DONTBUILD

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 9070343 [details] [diff] [review]
1556936-contentTabUrlbar.patch

This needs to go into the beta, right?

Comment 12

[Richard Marti (:Paenglab)]

Right. But not checked if it applies.

Comment 13

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/328a0e00ae35ec0a9b21aba2392bd4133cb3893d