1556987 - Invalid assertion in nsHttpChannel::OnPush

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Michal Novotny [:michal]]

Assertion at https://searchfox.org/mozilla-central/rev/9eb2f739c165b4e294929f7b99fbb4d90f8a396b/netwerk/protocol/http/nsHttpChannel.cpp#9278 is wrong. In nsHttpChannel::SetupTransaction we check whether notification callbacks implement nsIHttpPushListener and set NS_HTTP_ONPUSH_LISTENER capability if yes. But nsHttpChannel::OnPush event is initiated on socket thread in Http2PushedStream::TryOnPush and the channel can be closed and listeners released before nsHttpChannel::OnPush is called on the main thread.

Comment 1

[Michal Novotny [:michal]]

Attachment: Bug 1556987 - Invalid assertion in nsHttpChannel::OnPush, r=dragana

NS_HTTP_ONPUSH_LISTENER capability is set in nsHttpChannel::SetupTransaction when notification callbacks implement nsIHttpPushListener, but nsHttpChannel::OnPush event is initiated on socket thread in Http2PushedStream::TryOnPush and the channel can be closed and listeners released before nsHttpChannel::OnPush is called on the main thread.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5469953bfe6f
Invalid assertion in nsHttpChannel::OnPush, r=dragana

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5469953bfe6f