1557031 - devtools/client/inspector/<computed|boxmodel>/test/<browser_computed_pseudo-element_01.js | browser_boxmodel_pseudo-element.js> | leaked 2 window(s) until shutdown [url = <random_url>

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=250099817&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/PaXGORVDRKOz_fUnTvrVkQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-06-05T07:49:25.676Z] 07:49:25 INFO - GECKO(1449) | --DOMWINDOW == 31 (0x7f68ab621020) [pid = 1449] [serial = 261] [outer = (nil)] [url = chrome://devtools/content/inspector/markup/markup.xhtml]
[task 2019-06-05T07:49:25.677Z] 07:49:25 INFO - GECKO(1449) | --DOMWINDOW == 30 (0x7f67184574c0) [pid = 1449] [serial = 252] [outer = (nil)] [url = about:blank]
[task 2019-06-05T07:49:25.752Z] 07:49:25 INFO - GECKO(1449) | MEMORY STAT | vsize 3191MB | residentFast 415MB | heapAllocated 138MB
[task 2019-06-05T07:49:25.752Z] 07:49:25 INFO - TEST-OK | devtools/client/inspector/computed/test/browser_computed_select-and-copy-styles-02.js | took 7043ms
[task 2019-06-05T07:49:25.768Z] 07:49:25 INFO - GECKO(1449) | ++DOCSHELL 0x7f5550b57000 == 1 [pid = 1572] [id = {bf84f5b8-60ac-4139-949a-f2f3f72bd3ef}]
[task 2019-06-05T07:49:25.769Z] 07:49:25 INFO - GECKO(1449) | ++DOMWINDOW == 5 (0x7f5550bfb020) [pid = 1572] [serial = 32] [outer = (nil)]
[task 2019-06-05T07:49:25.785Z] 07:49:25 INFO - GECKO(1449) | [Child 1572, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-06-05T07:49:25.793Z] 07:49:25 INFO - GECKO(1449) | [Child 1572, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-06-05T07:49:25.833Z] 07:49:25 INFO - GECKO(1449) | ++DOMWINDOW == 6 (0x7f554f445400) [pid = 1572] [serial = 33] [outer = 0x7f5550bfb020]
[task 2019-06-05T07:49:25.854Z] 07:49:25 INFO - checking window state
[task 2019-06-05T07:49:25.922Z] 07:49:25 INFO - GECKO(1449) | ++DOMWINDOW == 31 (0x7f68a1975400) [pid = 1449] [serial = 276] [outer = 0x7f68b0c6cd40]
[task 2019-06-05T07:49:25.991Z] 07:49:25 INFO - GECKO(1449) | ++DOMWINDOW == 32 (0x7f68a1970400) [pid = 1449] [serial = 277] [outer = 0x7f68b0c6cd40]
[task 2019-06-05T07:49:27.176Z] 07:49:27 INFO - GECKO(1449) | --DOCSHELL 0x7faef8e55000 == 0 [pid = 1522] [id = {e2432f9c-9bb4-4562-8d02-dfe89455508b}] [url = about:blank]
<...>
[task 2019-06-05T07:49:44.036Z] 07:49:44 INFO - GECKO(1449) | => mFreeCount: 517808
[task 2019-06-05T07:49:44.036Z] 07:49:44 INFO - GECKO(1449) | => mShareCount: 554195
[task 2019-06-05T07:49:44.039Z] 07:49:44 INFO - GECKO(1449) | => mAdoptCount: 12780
[task 2019-06-05T07:49:44.040Z] 07:49:44 INFO - GECKO(1449) | => mAdoptFreeCount: 12950
[task 2019-06-05T07:49:44.040Z] 07:49:44 INFO - GECKO(1449) | => Process ID: 1449, Thread ID: 140088184350528
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | Main app process: exit 0
[task 2019-06-05T07:49:44.078Z] 07:49:44 ERROR - TEST-UNEXPECTED-FAIL | devtools/client/inspector/computed/test/browser_computed_pseudo-element_01.js | leaked 2 window(s) until shutdown [url = http://example.com/browser/devtools/client/inspector/computed/test/doc_pseudoelement.html]
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | devtools/client/inspector/computed/test/browser_computed_pseudo-element_01.js | windows(s) leaked: [pid = 1572] [serial = 17], [pid = 1572] [serial = 19]
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | devtools/client/inspector/computed/test/browser_computed_pseudo-element_01.js | This test created 1 hidden window(s)
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | devtools/client/inspector/computed/test/browser_computed_pseudo-element_01.js | This test created 1 hidden docshell(s)
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | devtools/client/inspector/computed/test/browser_computed_browser-styles.js | This test created 1 hidden window(s)
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | devtools/client/inspector/computed/test/browser_computed_browser-styles.js | This test created 1 hidden docshell(s)
[task 2019-06-05T07:49:44.078Z] 07:49:44 INFO - TEST-INFO | devtools/client/inspector/computed/test/browser_computed_cycle_color.js | This test created 1 hidden window(s)

Comment 1

[Alexandru Michis [:malexandru]]

The other failure is: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250099817&repo=autoland&lineNumber=4574

Razvan, can you check if this is caused by Bug 1555064 ?

Comment 2

[Razvan Caliman [:rcaliman]]

It's unlikely that Bug 1555064 causes this. That patch only deals with pseudo-classes like :hover, :active, etc., not with pseudo-elements like ::before or ::after which are the ones tested here.

I checked whether the fix for an earlier Bug 1546621, which does treat pseudo-elements, may be the cause. But that one landed a week ago and the intermittents seem to be more recent. That's probably not the culprit either.

Comment 3

[Intermittent Failures Robot]

36 failures in 997 pushes (0.036 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 17
• mozilla-central: 7
• mozilla-inbound: 12

Platform breakdown:

• linux64: 23
• macosx1010-64: 11
• linux64-ccov: 1
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-05&endday=2019-06-05&tree=all

Comment 4

[Intermittent Failures Robot]

27 failures in 1101 pushes (0.025 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 9
• autoland: 14
• try: 2
• mozilla-central: 2

Platform breakdown:

• linux64: 19
• macosx1010-64: 7
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-06&endday=2019-06-06&tree=all

Comment 5

[Andreea Pavel [:apavel]]

Nicolas can you take a look? can this be from bug 1551586 or bug 1555339?

Comment 6

[Intermittent Failures Robot]

54 failures in 955 pushes (0.057 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 39
• mozilla-inbound: 9
• mozilla-central: 5
• try: 1

Platform breakdown:

• macosx1010-64: 30
• linux64: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-07&endday=2019-06-07&tree=all

Comment 7

[Intermittent Failures Robot]

25 failures in 250 pushes (0.1 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• mozilla-inbound: 4
• try: 1
• mozilla-central: 5

Platform breakdown:

• linux64: 15
• macosx1010-64: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-08&endday=2019-06-08&tree=all

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Could be Bug 1555339 maybe? We're adding a new test, and I know from experience that might cause some effects in other tests.

Comment 9

[Andreea Pavel [:apavel]]

Nicolas could you work on a fix? it will soon reach the disable recommended queue. Should we disable the tests?

Comment 10

[Intermittent Failures Robot]

165 failures in 5197 pushes (0.032 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 95
• mozilla-central: 26
• mozilla-inbound: 39
• try: 5

Platform breakdown:

• linux64: 94
• macosx1010-64: 66
• linux64-ccov: 2
• windows7-32: 1
• windows10-64: 1
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-03&endday=2019-06-09&tree=all

Comment 11

[Intermittent Failures Robot]

31 failures in 680 pushes (0.046 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 21
• mozilla-central: 2
• mozilla-inbound: 6
• try: 2

Platform breakdown:

• macosx1010-64: 14
• linux64: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-10&endday=2019-06-10&tree=all

Comment 12

[Intermittent Failures Robot]

55 failures in 963 pushes (0.057 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 10
• autoland: 26
• mozilla-central: 6
• try: 13

Platform breakdown:

• linux64: 40
• macosx1010-64: 13
• linux64-qr: 1
• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-11&endday=2019-06-11&tree=all

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Maybe this is caused because we are now checking invalid width properties, and the test finished while we are doing some computation about that?
Andreea, Is there something to run the tests with the devtools.inspector.inactive.css.enabled preference set to false? That would be nice to see if my guess is valid.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Switching it to false seems to fix it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e75ee5dbe05f6bb16de9184f1910898a09536f92&selectedJob=251478132

Comment 15

[Intermittent Failures Robot]

50 failures in 973 pushes (0.051 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 27
• mozilla-inbound: 7
• try: 5
• mozilla-central: 11

Platform breakdown:

• macosx1010-64: 18
• linux64: 31
• linux64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-12&endday=2019-06-12&tree=all

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

Here's a TRY TV push on the 2 tests with a fix attempt: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c049fa9651ce24bcd673c4b37385584f19d8cc6b (locally TV ran fine, looks promising)

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1557031 - Fix test leaks caused by InactivePropertyHelper. r=miker.

We put some objects on the InactivePropertyHelper (node, rule),
but never reset those properties, which was causing leaks in some
inspector tests.
This patch adds a unselect function that clears all the references
added in the select function.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7914b5a848e
Fix test leaks caused by InactivePropertyHelper. r=miker.

Comment 19

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b7914b5a848e

Comment 20

[Intermittent Failures Robot]

30 failures in 951 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 9
• mozilla-inbound: 7
• mozilla-central: 4
• try: 10

Platform breakdown:

• linux64: 30

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-13&endday=2019-06-13&tree=all

Comment 21

[Intermittent Failures Robot]

170 failures in 4753 pushes (0.036 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 83
• mozilla-central: 23
• mozilla-inbound: 30
• try: 34

Platform breakdown:

• macosx1010-64: 45
• linux64: 122
• linux64-qr: 1
• linux64-shippable: 1
• linux64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1557031&startday=2019-06-10&endday=2019-06-16&tree=all