Closed Bug 1557051 Opened 6 months ago Closed 6 months ago

Enable QuantumBar for release users

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.2 - May 27 - Jun 9
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: standard8, Assigned: mak)

References

Details

Attachments

(1 file)

Currently QuantumBar is only enabled for EARLY_BETA_OR_EARLIER. That normally gets turned off between b8/b9 (which will be between Thursday and Monday).

From Mike de Boer on irc:

I think we need to enable it to ride 68
We don't have any real blockers left, so the call is good

This will also need uplifting to beta.

Assignee: nobody → mak77
Status: NEW → ASSIGNED

I should also add that our experiment didn't show any significant difference in users behaviors, that would have been an alarm signal.

Iteration: --- → 69.2 - May 27 - Jun 9
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/e5357685dd4e
Enable QuantumBar for release users. r=dao,adw

Comment on attachment 9069971 [details]
Bug 1557051 - Enable QuantumBar for release users.

Beta/Release Uplift Approval Request

  • User impact if declined: the Quantum Bar is currently only enabled for early beta, but it is expected to be enabled in release. b9 is likely to wrongly disable the feature.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): just removing the ifdef in prefs, the feature is already enabled in beta.
  • String changes made/needed:
Attachment #9069971 - Flags: approval-mozilla-beta?

Comment on attachment 9069971 [details]
Bug 1557051 - Enable QuantumBar for release users.

keep quantumbar enabled through release. approved for 68.0b8

Attachment #9069971 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.