1557063 - column-gap is incorrectly marked as invalid if not applied to a grid container

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Christian Sonne [:cers]]

Attachment: Test case

The property 'column-gap' is currently marked as invalid if not applied to a grid container, but this is false. It also applies to flex and multi-column containers.

STR:

1. load attached test case
2. inspect containers with class "gap"
3. look for column-gap rule in Rules view

Comment 1

[Patrick Brosset <:pbro>]

Thanks for filing!

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1557063 - Better checks for invalid CSS when using gap, column-gap and row-gap. r=miker

Splits the checks by appropriate container:

• column-gap and gap for flex-container, grid-container and multi-column container
• row-gap only for flex container and grid container

See CSS Box Alignment: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Alignment

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed1862121e9a
Better checks for invalid CSS when using gap, column-gap and row-gap. r=miker,fluent-reviewers,flod

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ed1862121e9a

Comment 5

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0a1(2019-06-05).
Verified fix with 69.0a1 (2019-07-07).