Closed Bug 1557063 Opened 5 years ago Closed 5 years ago

column-gap is incorrectly marked as invalid if not applied to a grid container

Categories

(DevTools :: Inspector: Rules, defect, P1)

defect

Tracking

(firefox69 verified)

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: cers, Assigned: rcaliman)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Importance: 1.1%])

Attachments

(2 files)

Attached file Test case

The property 'column-gap' is currently marked as invalid if not applied to a grid container, but this is false. It also applies to flex and multi-column containers.

STR:

  1. load attached test case
  2. inspect containers with class "gap"
  3. look for column-gap rule in Rules view

Thanks for filing!

No longer regressed by: 1306054
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Priority: -- → P1

Splits the checks by appropriate container:

  • column-gap and gap for flex-container, grid-container and multi-column container
  • row-gap only for flex container and grid container

See CSS Box Alignment: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Alignment

Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed1862121e9a
Better checks for invalid CSS when using gap, column-gap and row-gap. r=miker,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Confirmed issue with 69.0a1(2019-06-05).
Verified fix with 69.0a1 (2019-07-07).

Status: RESOLVED → VERIFIED
Whiteboard: [Importance: 1.1%]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: