Closed Bug 1557162 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17196 - [css-contain] Fix <select> dimensions when size containment is set

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17196 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17196
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

[css-contain] Fix <select> dimensions when size containment is set

In r666210 we fixed the dimensions of \<select> elements
with size containment.
However the fix was not covering the case when you set
"contain: size" to an already existent \<select> element.

To fix this we need to reset the options width
in LayoutMenuList::UpdateOptionsWidth().

BUG=966673
TEST=external/wpt/css/css-contain/contain-size-select-002.html

Change-Id: I162134ff050d64e9ff1d824b5747adafb9a993c6
Reviewed-on: https://chromium-review.googlesource.com/1647152
WPT-Export-Revision: 81f8aeda5c90c25ab0abdd6ade1bab1f7726fda2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9d6722d8194 [wpt PR 17196] - [css-contain] Fix <select> dimensions when size containment is set, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a9d6722d8194

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.