1557164 - [mips*] xptcstubsdef.inc:1:94: error: unknown directive

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect)

Description

[Mike Hommey [:glandium]]

ERROR -  /builds/worker/workspace/build/src/xpcom/reflect/xptcall/xptcstubsdef.inc:1:94: error: unknown directive
INFO -  .if 3 < 10; .globl _ZN14nsXPTCStubBase5Stub3Ev; .type _ZN14nsXPTCStubBase5Stub3Ev,@function; .aent _ZN14nsXPTCStubBase5Stub3Ev,0; _ZN14nsXPTCStubBase5Stub3Ev:; dsubu $29,FRAMESZ; .cpsetup $25, GPOFF, _ZN14nsXPTCStubBase5Stub3Ev; li $12,3; b sharedstub;; .elseif 3 < 100; .globl _ZN14nsXPTCStubBase6Stub3Ev; .type _ZN14nsXPTCStubBase6Stub3Ev,@function; .aent _ZN14nsXPTCStubBase6Stub3Ev,0; _ZN14nsXPTCStubBase6Stub3Ev:; dsubu $29,FRAMESZ; .cpsetup $25, GPOFF, _ZN14nsXPTCStubBase6Stub3Ev; li $12,3; b sharedstub;; .elseif 3 < 1000; .globl _ZN14nsXPTCStubBase7Stub3Ev; .type _ZN14nsXPTCStubBase7Stub3Ev,@function; .aent _ZN14nsXPTCStubBase7Stub3Ev,0; _ZN14nsXPTCStubBase7Stub3Ev:; dsubu $29,FRAMESZ; .cpsetup $25, GPOFF, _ZN14nsXPTCStubBase7Stub3Ev; li $12,3; b sharedstub;; .else; .err; .endif
INFO -                                                                                               ^

This is because clang integrated assembler doesn't support the .aent directive (filed https://bugs.llvm.org/show_bug.cgi?id=42134)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1557164 - Don't use integrated assembler with clang on mips*.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eca88f6069a7
Don't use integrated assembler with clang on mips*. r=froydnj

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9070098 [details]
Bug 1557164 - Don't use integrated assembler with clang on mips*.

Beta/Release Uplift Approval Request

• User impact if declined: Build failure on Debian mips, mipsel, mips64el (tier 3) when compiling with clang. Would be nice to have for downstreams on ESR68.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB for what Mozilla ships.
• String changes made/needed:

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9070098 [details]
Bug 1557164 - Don't use integrated assembler with clang on mips*.

tier3 build fix, approved for 68.0b8

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/eca88f6069a7

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e74c38d7d3f3