Closed Bug 1557193 Opened 6 months ago Closed 5 months ago

ScriptSource compression test improvements

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(5 files)

We don't have UTF-8 testing yet because it wasn't feasible yet when the test was written. And we're not definitely testing compression because a line wasn't uncommented in a post-review comment in bug 1511595. :-( And -- shocker of shockers -- turns out uncommenting doesn't actually work, albeit at least for silly reasons.

Priority: -- → P1
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f9525b968a4
Change testScriptSourceCompression.cpp to use Unit for source-unit typename, not CharT, consistent with the code it invokes in the frontend.  r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f7ad18b80d8
Move Unit-agnostic code out of the Evaluate helper function in testScriptSourceCompression.cpp.  r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/df3f47aa137d
Implement various tweaks needed for the Unit-agnostic code to work for UTF-8.  r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/15707f7932bb
Make testScriptSourceCompression.cpp run all its tests with UTF-8 in addition to UTF-16 source.  r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef74cdc4c8a4
Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously.  r=arai, r=jonco
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

It looks increasingly parlous trying to get a "natural" script source compression to happen -- ScriptSource::tryCompressOffThread in a number of cases will not actually compress, and replicating those conditions in even a test-only predicate seems frail. So a testing function that artificially forces compression essentially directly seems best. I have a patch for this -- a grody one (even if it mostly reuses existing functions unaltered), but a patch nonetheless. Will post for review when a try-run proceeds somewhat further than it has at this point.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=640197947621100734f530e6fdfd90d5c17cb3e4&selectedJob=251055633

Flags: needinfo?(jwalden)
Attachment #9070129 - Attachment description: Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai!,jonco! → Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai, r=jonco!, r=sfink!
Attachment #9070129 - Attachment description: Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai, r=jonco!, r=sfink! → Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai,jonco!,sfink!
Attachment #9070129 - Attachment description: Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai,jonco!,sfink! → Bug 1557193 - Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously. r=arai, r=jonco, r=sfink
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/a496acc65759
Enable the assertion in testScriptSourceCompression.cpp verifying that script source was, in fact, compressed off-thread synchronously.  r=arai,jonco,sfink
Status: REOPENED → RESOLVED
Closed: 6 months ago5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.